rename

Author: asmyasnikov

CHANGELOG.md

@@ -1,4 +1,4 @@
-* Added binding `ydb.WithWideTypes()` which interprets `time.Time` and `time.Duration` as `Timestamp64` and `Interval64` YDB types
+* Added binding `ydb.WithWideTimeTypes()` which interprets `time.Time` and `time.Duration` as `Timestamp64` and `Interval64` YDB types
 
 ## v3.103.0
 * Supported wide `Interval64` type

internal/bind/wide_types.go renamed to internal/bind/wide_time_types.go

@@ -6,9 +6,9 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/value"
 )
 
-type WideTypes struct{}
+type WideTimeTypes struct{}
 
-func (m WideTypes) ToYdb(sql string, args ...any) (yql string, newArgs []any, _ error) {
+func (m WideTimeTypes) ToYdb(sql string, args ...any) (yql string, newArgs []any, _ error) {
 	newArgs = make([]any, 0, len(args))
 	for _, arg := range args {
 		switch t := arg.(type) {
@@ -24,6 +24,6 @@ func (m WideTypes) ToYdb(sql string, args ...any) (yql string, newArgs []any, _
 	return sql, newArgs, nil
 }
 
-func (m WideTypes) blockID() blockID {
+func (m WideTimeTypes) blockID() blockID {
 	return blockCastArgs
 }

internal/bind/wide_types_test.go renamed to internal/bind/wide_time_types_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/value"
 )
 
-func TestWideTypesBindRewriteQuery(t *testing.T) {
+func TestWideTimeTypesBind(t *testing.T) {
 	for _, tt := range []struct {
 		bind   Bind
 		sql    string
@@ -58,7 +58,7 @@ func TestWideTypesBindRewriteQuery(t *testing.T) {
 			},
 		},
 		{
-			bind: WideTypes{},
+			bind: WideTimeTypes{},
 			sql:  `SELECT ?, ?`,
 			args: []any{
 				100,
@@ -71,7 +71,7 @@ func TestWideTypesBindRewriteQuery(t *testing.T) {
 			},
 		},
 		{
-			bind: WideTypes{},
+			bind: WideTimeTypes{},
 			sql:  `SELECT ?, ?`,
 			args: []any{
 				time.Unix(123, 456),
@@ -84,7 +84,7 @@ func TestWideTypesBindRewriteQuery(t *testing.T) {
 			},
 		},
 		{
-			bind: WideTypes{},
+			bind: WideTimeTypes{},
 			sql:  `SELECT ?, ?`,
 			args: []any{
 				time.Duration(123) * time.Millisecond,

internal/value/value.go

@@ -486,7 +486,7 @@ func (v date32Value) toYDB(a *allocator.Allocator) *Ydb.Value {
 	return vvv
 }
 
-// Date32Value returns ydb date value by given days since Epoch
+// Date32Value returns ydb date value from days around epoch time
 func Date32Value(v int32) date32Value {
 	return date32Value(v)
 }
@@ -596,7 +596,7 @@ func (v datetime64Value) toYDB(a *allocator.Allocator) *Ydb.Value {
 	return vvv
 }
 
-// Datetime64Value makes ydb datetime value from seconds since Epoch
+// Datetime64Value makes ydb datetime value from seconds around epoch time
 func Datetime64Value(v int64) datetime64Value {
 	return datetime64Value(v)
 }
@@ -1385,7 +1385,7 @@ func (v interval64Value) toYDB(a *allocator.Allocator) *Ydb.Value {
 	return vvv
 }
 
-// Interval64Value makes Value from given microseconds value
+// Interval64Value makes Value from given nanoseconds around epoch time
 func Interval64Value(v int64) interval64Value {
 	return interval64Value(v)
 }
@@ -2011,7 +2011,7 @@ func (v timestamp64Value) toYDB(a *allocator.Allocator) *Ydb.Value {
 	return vvv
 }
 
-// Timestamp64Value makes ydb timestamp value by given microseconds since Epoch
+// Timestamp64Value makes ydb timestamp value by given signed microseconds around Epoch
 func Timestamp64Value(v int64) timestamp64Value {
 	return timestamp64Value(v)
 }

query_bind_test.go

@@ -583,7 +583,7 @@ SELECT $p0;`,
 			b: testutil.QueryBind(
 				ydb.WithAutoDeclare(),
 				ydb.WithPositionalArgs(),
-				ydb.WithWideTypes(),
+				ydb.WithWideTimeTypes(),
 			),
 			sql:  `SELECT ?;`,
 			args: []interface{}{time.Unix(123, 456)},

sql.go

@@ -189,8 +189,8 @@ func WithPositionalArgs() QueryBindConnectorOption {
 	return xsql.WithQueryBind(bind.PositionalArgs{})
 }
 
-func WithWideTypes() QueryBindConnectorOption {
-	return xsql.WithQueryBind(bind.WideTypes{})
+func WithWideTimeTypes() QueryBindConnectorOption {
+	return xsql.WithQueryBind(bind.WideTimeTypes{})
 }
 
 func WithNumericArgs() QueryBindConnectorOption {