* Refactored errors wrapping (stackedError are not ydb error now, checking errors.IsYdb(err) with errors.As now)

Author: asmyasnikov

CHANGELOG.md

@@ -1,6 +1,7 @@
 * Refactored `cluster.Cluster` and `balancer.Balancer` interfaces (removed `Update` method)
 * Replaced `cluster.Update` with `cluster.Remove` and `cluster.Insert` calls
 * Fixed bug with unexpected changing of local datacenter flag in endpoint
+* Refactored errors wrapping (stackedError are not ydb error now, checking `errors.IsYdb(err)` with `errors.As` now)
 
 ## v3.16.9
 * Refactored internal operation and transport errors

internal/cluster/cluster.go

@@ -24,10 +24,10 @@ const (
 
 var (
 	// ErrClusterClosed returned when requested on a closed cluster.
-	ErrClusterClosed = fmt.Errorf("cluster closed")
+	ErrClusterClosed = errors.New(fmt.Errorf("cluster closed"))
 
 	// ErrClusterEmpty returned when no connections left in cluster.
-	ErrClusterEmpty = fmt.Errorf("cluster empty")
+	ErrClusterEmpty = errors.New(fmt.Errorf("cluster empty"))
 )
 
 type cluster struct {

internal/conn/conn.go

@@ -20,9 +20,9 @@ import (
 
 var (
 	// errOperationNotReady specified error when operation is not ready
-	errOperationNotReady = fmt.Errorf("operation is not ready yet")
+	errOperationNotReady = errors.New(fmt.Errorf("operation is not ready yet"))
 	// errClosedConnection specified error when connection are closed early
-	errClosedConnection = fmt.Errorf("connection closed early")
+	errClosedConnection = errors.New(fmt.Errorf("connection closed early"))
 )
 
 type Conn interface {
@@ -374,7 +374,7 @@ func (c *conn) Invoke(
 
 			case o.GetOperation().GetStatus() != Ydb.StatusIds_SUCCESS:
 				return errors.WithStackTrace(
-					errors.NewOpError(
+					errors.Operation(
 						errors.FromOperation(
 							o.GetOperation(),
 						),

internal/conn/grpc_client_stream.go

@@ -88,7 +88,7 @@ func (s *grpcClientStream) RecvMsg(m interface{}) (err error) {
 		if operation, ok := m.(wrap.StreamOperationResponse); ok {
 			if s := operation.GetStatus(); s != Ydb.StatusIds_SUCCESS {
 				return errors.WithStackTrace(
-					errors.NewOpError(
+					errors.Operation(
 						errors.FromOperation(
 							operation,
 						),

internal/credentials/credentials.go

@@ -10,7 +10,7 @@ import (
 // errNoCredentials may be returned by Credentials implementations to
 // make driver act as if there are no Credentials at all. That is, driver will
 // not send any token meta information during request.
-var errNoCredentials = fmt.Errorf("ydb: credentials: no credentials")
+var errNoCredentials = errors.New(fmt.Errorf("ydb: credentials: no credentials"))
 
 // Credentials is an interface that contains options used to authorize a
 // client.

internal/decimal/errors.go

@@ -1,8 +1,12 @@
 package decimal
 
-import "fmt"
+import (
+	"fmt"
 
-var ErrSyntax = fmt.Errorf("invalid syntax")
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/errors"
+)
+
+var errSyntax = errors.New(fmt.Errorf("invalid syntax"))
 
 type ParseError struct {
 	Err   error
@@ -21,7 +25,7 @@ func (p *ParseError) Unwrap() error {
 
 func syntaxError(s string) *ParseError {
 	return &ParseError{
-		Err:   ErrSyntax,
+		Err:   errSyntax,
 		Input: s,
 	}
 }

internal/dsn/dsn.go

@@ -21,8 +21,8 @@ var (
 		"grpcs": true,
 		"grpc":  false,
 	}
-	errSchemeNotValid = fmt.Errorf("schema not valid")
-	errParserExists   = fmt.Errorf("already exists parser. newest parser replaced old. param")
+	errSchemeNotValid = errors.New(fmt.Errorf("schema not valid"))
+	errParserExists   = errors.New(fmt.Errorf("already exists parser. newest parser replaced old. param"))
 )
 
 type Parser func(value string) ([]config.Option, error)

internal/errors/check.go

@@ -9,7 +9,7 @@ func Check(err error) (
 ) {
 	var te *transportError
 	var oe *operationError
-	var re *RetryableError
+	var re *retryableError
 	switch {
 	case As(err, &te):
 		return int64(te.code),
@@ -24,8 +24,8 @@ func Check(err error) (
 	case As(err, &re):
 		return -1,
 			OperationNotFinished,
-			re.BackoffType,
-			re.MustDeleteSession
+			re.backoffType,
+			re.mustDeleteSession
 	default:
 		return -1,
 			OperationFinished, // it's finished, not need any retry attempts

internal/errors/errors.go

@@ -3,7 +3,6 @@ package errors
 import (
 	"context"
 	"errors"
-	"fmt"
 	"io"
 
 	grpcCodes "google.golang.org/grpc/codes"
@@ -82,9 +81,3 @@ func Is(err error, targets ...error) bool {
 	}
 	return false
 }
-
-// New is a proxy to errors.New
-// This need to single import errors
-func New(text string) error {
-	return WithStackTrace(fmt.Errorf("%w", errors.New(text)), WithSkipDepth(1))
-}

internal/errors/operation.go

@@ -30,23 +30,23 @@ type operation interface {
 }
 
 // WithIssues is an option for construct operation error with issues list
-// WithIssues must use as `NewOpError(WithIssues(issues))`
+// WithIssues must use as `Operation(WithIssues(issues))`
 func WithIssues(issues []*Ydb_Issue.IssueMessage) oeOpt {
 	return func(oe *operationError) {
 		oe.issues = issues
 	}
 }
 
 // WithStatusCode is an option for construct operation error with reason code
-// WithStatusCode must use as `NewOpError(WithStatusCode(reason))`
+// WithStatusCode must use as `Operation(WithStatusCode(reason))`
 func WithStatusCode(code Ydb.StatusIds_StatusCode) oeOpt {
 	return func(oe *operationError) {
 		oe.code = code
 	}
 }
 
 // FromOperation is an option for construct operation error from operation
-// FromOperation must use as `NewOpError(FromOperation(operation))`
+// FromOperation must use as `Operation(FromOperation(operation))`
 func FromOperation(operation operation) oeOpt {
 	return func(oe *operationError) {
 		oe.code = operation.GetStatus()
@@ -56,7 +56,7 @@ func FromOperation(operation operation) oeOpt {
 
 type oeOpt func(ops *operationError)
 
-func NewOpError(opts ...oeOpt) error {
+func Operation(opts ...oeOpt) error {
 	oe := &operationError{
 		code: Ydb.StatusIds_STATUS_CODE_UNSPECIFIED,
 	}