Merge pull request #244 from ydb-platform/drop-grpc-client-conn-interface

* Removed from `ydb.Connection` embedding of `grpc.ClientConnInterface`

Author: asmyasnikov

CHANGELOG.md

@@ -1,4 +1,5 @@
 * Fixed bug with convertation `time.Duration` from/to YDB value
+* Removed from `ydb.Connection` embedding of `grpc.ClientConnInterface`
 * Fixed stopping of repeater
 * Added hard minimal interval (1 second) between force wake up's 
 * Renamed `trace.DriverRepeaterTick{Start,Done}Info` to `trace.DriverRepeaterWakeUp{Start,Done}Info`

connection.go

@@ -40,9 +40,6 @@ import (
 // This interface is central part for access to various systems
 // embedded to ydb through one configured connection method.
 type Connection interface {
-	// ClientConnInterface provide execute unary and streaming RPC over internal balancer
-	grpc.ClientConnInterface
-
 	// Endpoint returns initial endpoint
 	Endpoint() string
 
@@ -118,6 +115,8 @@ type connection struct {
 	panicCallback func(e interface{})
 }
 
+var _ grpc.ClientConnInterface = (*connection)(nil)
+
 func (c *connection) Close(ctx context.Context) error {
 	c.mtx.Lock()
 	defer c.mtx.Unlock()

connection_e2e_test.go

@@ -123,7 +123,7 @@ func TestConnection(t *testing.T) {
 	}()
 	t.Run("discovery.WhoAmI", func(t *testing.T) {
 		if err = retry.Retry(ctx, func(ctx context.Context) (err error) {
-			discoveryClient := Ydb_Discovery_V1.NewDiscoveryServiceClient(db)
+			discoveryClient := Ydb_Discovery_V1.NewDiscoveryServiceClient(db.(grpc.ClientConnInterface))
 			response, err := discoveryClient.WhoAmI(
 				ctx,
 				&Ydb_Discovery.WhoAmIRequest{IncludeGroups: true},
@@ -143,7 +143,7 @@ func TestConnection(t *testing.T) {
 	})
 	t.Run("scripting.ExecuteYql", func(t *testing.T) {
 		if err = retry.Retry(ctx, func(ctx context.Context) (err error) {
-			scriptingClient := Ydb_Scripting_V1.NewScriptingServiceClient(db)
+			scriptingClient := Ydb_Scripting_V1.NewScriptingServiceClient(db.(grpc.ClientConnInterface))
 			response, err := scriptingClient.ExecuteYql(
 				ctx,
 				&Ydb_Scripting.ExecuteYqlRequest{Script: "SELECT 1+100 AS sum"},
@@ -194,7 +194,7 @@ func TestConnection(t *testing.T) {
 	})
 	t.Run("scripting.StreamExecuteYql", func(t *testing.T) {
 		if err = retry.Retry(ctx, func(ctx context.Context) (err error) {
-			scriptingClient := Ydb_Scripting_V1.NewScriptingServiceClient(db)
+			scriptingClient := Ydb_Scripting_V1.NewScriptingServiceClient(db.(grpc.ClientConnInterface))
 			client, err := scriptingClient.StreamExecuteYql(
 				ctx,
 				&Ydb_Scripting.ExecuteYqlRequest{Script: "SELECT 1+100 AS sum"},
@@ -248,7 +248,7 @@ func TestConnection(t *testing.T) {
 			_ = childDB.Close(ctx)
 		}()
 		if err = retry.Retry(ctx, func(ctx context.Context) (err error) {
-			scriptingClient := Ydb_Scripting_V1.NewScriptingServiceClient(childDB)
+			scriptingClient := Ydb_Scripting_V1.NewScriptingServiceClient(childDB.(grpc.ClientConnInterface))
 			client, err := scriptingClient.StreamExecuteYql(
 				ctx,
 				&Ydb_Scripting.ExecuteYqlRequest{Script: "SELECT 1+100 AS sum"},
@@ -291,7 +291,7 @@ func TestConnection(t *testing.T) {
 	})
 	t.Run("export.ExportToS3", func(t *testing.T) {
 		if err = retry.Retry(ctx, func(ctx context.Context) (err error) {
-			exportClient := Ydb_Export_V1.NewExportServiceClient(db)
+			exportClient := Ydb_Export_V1.NewExportServiceClient(db.(grpc.ClientConnInterface))
 			response, err := exportClient.ExportToS3(
 				ctx,
 				&Ydb_Export.ExportToS3Request{