Skip to content

Commit dab4dca

Browse files
committed
make transaction internal public
1 parent b5d1297 commit dab4dca

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

internal/query/execute_query.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func queryFromText(
5353
}
5454

5555
func execute(ctx context.Context, s *Session, c Ydb_Query_V1.QueryServiceClient, q string, cfg executeConfig) (
56-
_ *transaction, _ *result, finalErr error,
56+
_ *Transaction, _ *result, finalErr error,
5757
) {
5858
a := allocator.New()
5959
defer a.Free()

internal/query/session.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ func begin(
235235
client Ydb_Query_V1.QueryServiceClient,
236236
s *Session,
237237
txSettings query.TransactionSettings,
238-
) (*transaction, error) {
238+
) (*Transaction, error) {
239239
a := allocator.New()
240240
defer a.Free()
241241
response, err := client.BeginTransaction(ctx,
@@ -257,7 +257,7 @@ func (s *Session) Begin(
257257
) (
258258
_ query.Transaction, err error,
259259
) {
260-
var tx *transaction
260+
var tx *Transaction
261261

262262
onDone := trace.QueryOnSessionBegin(s.cfg.Trace(), &ctx,
263263
stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/3/internal/query.(*Session).Begin"), s)

internal/query/transaction.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ import (
1515
"github.com/ydb-platform/ydb-go-sdk/v3/trace"
1616
)
1717

18-
var _ query.Transaction = (*transaction)(nil)
18+
var _ query.Transaction = (*Transaction)(nil)
1919

20-
type transaction struct {
20+
type Transaction struct {
2121
tx.Identifier
2222

2323
s *Session
2424
}
2525

26-
func (tx transaction) ReadRow(ctx context.Context, q string, opts ...options.TxExecuteOption) (row query.Row, _ error) {
26+
func (tx Transaction) ReadRow(ctx context.Context, q string, opts ...options.TxExecuteOption) (row query.Row, _ error) {
2727
r, err := tx.Execute(ctx, q, opts...)
2828
if err != nil {
2929
return nil, xerrors.WithStackTrace(err)
@@ -42,7 +42,7 @@ func (tx transaction) ReadRow(ctx context.Context, q string, opts ...options.TxE
4242
return row, nil
4343
}
4444

45-
func (tx transaction) ReadResultSet(ctx context.Context, q string, opts ...options.TxExecuteOption) (
45+
func (tx Transaction) ReadResultSet(ctx context.Context, q string, opts ...options.TxExecuteOption) (
4646
rs query.ResultSet, _ error,
4747
) {
4848
r, err := tx.Execute(ctx, q, opts...)
@@ -63,18 +63,18 @@ func (tx transaction) ReadResultSet(ctx context.Context, q string, opts ...optio
6363
return rs, nil
6464
}
6565

66-
func newTransaction(id string, s *Session) *transaction {
67-
return &transaction{
66+
func newTransaction(id string, s *Session) *Transaction {
67+
return &Transaction{
6868
Identifier: tx.ID(id),
6969
s: s,
7070
}
7171
}
7272

73-
func (tx transaction) Execute(ctx context.Context, q string, opts ...options.TxExecuteOption) (
73+
func (tx Transaction) Execute(ctx context.Context, q string, opts ...options.TxExecuteOption) (
7474
r query.Result, finalErr error,
7575
) {
7676
onDone := trace.QueryOnTxExecute(tx.s.cfg.Trace(), &ctx,
77-
stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/3/internal/query.transaction.Execute"), tx.s, tx, q)
77+
stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/3/internal/query.Transaction.Execute"), tx.s, tx, q)
7878
defer func() {
7979
onDone(finalErr)
8080
}()
@@ -103,7 +103,7 @@ func commitTx(ctx context.Context, client Ydb_Query_V1.QueryServiceClient, sessi
103103
return nil
104104
}
105105

106-
func (tx transaction) CommitTx(ctx context.Context) error {
106+
func (tx Transaction) CommitTx(ctx context.Context) error {
107107
err := commitTx(ctx, tx.s.grpcClient, tx.s.id, tx.ID())
108108
if err != nil {
109109
if xerrors.IsOperationError(err, Ydb.StatusIds_BAD_SESSION) {
@@ -128,7 +128,7 @@ func rollback(ctx context.Context, client Ydb_Query_V1.QueryServiceClient, sessi
128128
return nil
129129
}
130130

131-
func (tx transaction) Rollback(ctx context.Context) error {
131+
func (tx Transaction) Rollback(ctx context.Context) error {
132132
err := rollback(ctx, tx.s.grpcClient, tx.s.id, tx.ID())
133133
if err != nil {
134134
if xerrors.IsOperationError(err, Ydb.StatusIds_BAD_SESSION) {

0 commit comments

Comments
 (0)