Skip to content

Commit ddc3d11

Browse files
authored
Merge pull request #770 from ydb-platform/slo-fixes
test(slo): xorm fixes
2 parents 0db9c82 + 1b6a04d commit ddc3d11

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

.github/workflows/slo.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
uses: actions/checkout@v3
2525

2626
- name: Run SLO
27-
uses: ydb-platform/slo-tests@additional-logs
27+
uses: ydb-platform/slo-tests@js-version
2828
with:
2929
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3030
KUBECONFIG_B64: ${{ secrets.SLO_KUBE_CONFIG }}

tests/slo/internal/generator/row.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import "time"
55
type RowID = uint64
66

77
type Row struct {
8-
Hash uint64 `gorm:"column:hash;primarykey;autoIncrement:false" xorg:"pk 'hash'"`
8+
Hash uint64 `gorm:"column:hash;primarykey;autoIncrement:false" xorm:"pk 'hash'"`
99
ID RowID `gorm:"column:id;primarykey;autoIncrement:false" xorm:"pk 'id'"`
1010
PayloadStr *string `gorm:"column:payload_str" xorm:"'payload_str'"`
1111
PayloadDouble *float64 `gorm:"column:payload_double" xorm:"'payload_double'"`

tests/slo/xorm/storage.go

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,11 @@ func NewStorage(ctx context.Context, cfg *config.Config, poolSize int) (_ *Stora
102102
return nil, err
103103
}
104104

105-
s.x.DB().SetMaxOpenConns(poolSize)
106-
s.x.DB().SetMaxIdleConns(poolSize)
107-
s.x.DB().SetConnMaxIdleTime(time.Second)
105+
s.x.SetMaxOpenConns(poolSize)
106+
s.x.SetMaxIdleConns(poolSize)
107+
s.x.SetConnMaxIdleTime(time.Second)
108108

109-
s.x.SetTableMapper(newMapper(cfg.Table, "entry"))
109+
s.x.SetTableMapper(newMapper(cfg.Table, cfg.Table))
110110

111111
s.x.SetLogLevel(log.LOG_DEBUG)
112112

@@ -134,8 +134,8 @@ func (s *Storage) Read(ctx context.Context, id generator.RowID) (row generator.R
134134
row.ID = id
135135

136136
err = retry.Do(ydb.WithTxControl(ctx, readTx), s.x.DB().DB,
137-
func(ctx context.Context, cc *sql.Conn) (err error) {
138-
has, err := s.x.Context(ctx).Get(&row)
137+
func(ctx context.Context, _ *sql.Conn) (err error) {
138+
has, err := s.x.Context(ctx).Where("hash = Digest::NumericHash(?)", id).Get(&row)
139139
if err != nil {
140140
return fmt.Errorf("get entry error: %w", err)
141141
}
@@ -173,7 +173,7 @@ func (s *Storage) Write(ctx context.Context, row generator.Row) (attempts int, e
173173
defer cancel()
174174

175175
err = retry.Do(ydb.WithTxControl(ctx, writeTx), s.x.DB().DB,
176-
func(ctx context.Context, cc *sql.Conn) (err error) {
176+
func(ctx context.Context, _ *sql.Conn) (err error) {
177177
if err = ctx.Err(); err != nil {
178178
return err
179179
}
@@ -208,7 +208,9 @@ func (s *Storage) createTable(ctx context.Context) error {
208208
ctx, cancel := context.WithTimeout(ctx, time.Duration(s.cfg.WriteTimeout)*time.Millisecond)
209209
defer cancel()
210210

211-
return s.x.Context(ctx).CreateTable(generator.Row{})
211+
return retry.Do(ctx, s.x.DB().DB, func(ctx context.Context, _ *sql.Conn) error {
212+
return s.x.Context(ctx).CreateTable(generator.Row{})
213+
})
212214
}
213215

214216
func (s *Storage) dropTable(ctx context.Context) error {
@@ -219,7 +221,9 @@ func (s *Storage) dropTable(ctx context.Context) error {
219221
ctx, cancel := context.WithTimeout(ctx, time.Duration(s.cfg.WriteTimeout)*time.Millisecond)
220222
defer cancel()
221223

222-
return s.x.Context(ctx).DropTable(generator.Row{})
224+
return retry.Do(ctx, s.x.DB().DB, func(ctx context.Context, _ *sql.Conn) error {
225+
return s.x.Context(ctx).DropTable(generator.Row{})
226+
})
223227
}
224228

225229
func (s *Storage) close(ctx context.Context) error {

0 commit comments

Comments
 (0)