Skip to content

Commit dfc7f63

Browse files
authored
Merge pull request #556 from ydb-platform/remove-skip
remove skipping tests for testing with latest docker image
2 parents 4d70eab + 889d50c commit dfc7f63

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

.github/scripts/wait-ydb-container.sh

Lines changed: 0 additions & 7 deletions
This file was deleted.

.github/workflows/tests.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
os: [ubuntu-latest]
4444
services:
4545
ydb:
46-
image: cr.yandex/yc/yandex-docker-local-ydb:latest
46+
image: cr.yandex/yc/yandex-docker-local-ydb:stable-22-5-slim
4747
ports:
4848
- 2135:2135
4949
- 2136:2136
@@ -69,8 +69,6 @@ jobs:
6969
go-version: ${{ matrix.go-version }}
7070
- name: Checkout code
7171
uses: actions/checkout@v3
72-
- name: Wait database available
73-
run: bash ./.github/scripts/wait-ydb-container.sh
7472
- name: Integration test
7573
run: go test -race -coverpkg=./... -coverprofile integration-secure.txt -covermode atomic ./tests
7674
- name: Upload Test secure connection coverage report to Codecov
@@ -89,7 +87,7 @@ jobs:
8987
os: [ubuntu-latest]
9088
services:
9189
ydb:
92-
image: cr.yandex/yc/yandex-docker-local-ydb:latest
90+
image: cr.yandex/yc/yandex-docker-local-ydb:stable-22-5-slim
9391
ports:
9492
- 2135:2135
9593
- 2136:2136
@@ -114,8 +112,6 @@ jobs:
114112
go-version: ${{ matrix.go-version }}
115113
- name: Checkout code
116114
uses: actions/checkout@v3
117-
- name: Wait database available
118-
run: bash ./.github/scripts/wait-ydb-container.sh
119115
- name: Test insecure connection
120116
run: go test -race -coverpkg=./... -coverprofile integration-insecure.txt -covermode atomic ./tests
121117
- name: Upload Test insecure connection coverage report to Codecov

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
* Added `internal/xerrors.Errorf` error for wrap multiple errors and check them with `errors.Is` of `errors.As`
22
* Fixed corner cases of `internal/wait.Wait`
3+
* Added check of port in connection string and erro throw
4+
* Fixed bug with initialization of connection pool before apply static credentials
5+
* Refactored of applying grpc dial options with defaults
36

47
## v3.42.8
58
* Fixed `internal/scheme/helpers/IsDirectoryExists(..)` recursive bug

tests/monitoring_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ import (
1818
)
1919

2020
func TestMonitoring(t *testing.T) {
21-
t.Skip("wait for newest cr.yandex/yc/yandex-docker-local-ydb:latest was published")
22-
2321
ctx, cancel := context.WithTimeout(context.Background(), time.Second*10)
2422
defer cancel()
2523

tests/static_credentials_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ import (
2020
)
2121

2222
func TestStaticCredentials(t *testing.T) {
23-
t.Skip("wait for newest cr.yandex/yc/yandex-docker-local-ydb:latest was published")
24-
2523
ctx, cancel := context.WithTimeout(context.Background(), time.Second*10)
2624
defer cancel()
2725

0 commit comments

Comments
 (0)