added tests for check BAD_SESSION retry status

Author: asmyasnikov

internal/conn/error_test.go

@@ -5,6 +5,10 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
+	"github.com/ydb-platform/ydb-go-genproto/protos/Ydb"
+
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/backoff"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 )
 
 func TestNodeErrorError(t *testing.T) {
@@ -59,3 +63,17 @@ func TestNodeErrorAs(t *testing.T) {
 	target2 := testType2Error{}
 	require.False(t, errors.As(nodeErr, &target2))
 }
+
+// https://github.com/ydb-platform/ydb-go-sdk/issues/1227
+func TestIssue1227NodeErrorUnwrapBadSession(t *testing.T) {
+	nodeErr := xerrors.WithStackTrace(newConnError(1, "localhost:1234", xerrors.Operation(
+		xerrors.WithStatusCode(Ydb.StatusIds_BAD_SESSION),
+	)))
+
+	code, errType, backoffType, invalidObject := xerrors.Check(nodeErr)
+
+	require.EqualValues(t, Ydb.StatusIds_BAD_SESSION, code)
+	require.EqualValues(t, xerrors.TypeRetryable, errType)
+	require.EqualValues(t, backoff.TypeNoBackoff, backoffType)
+	require.True(t, invalidObject)
+}

tests/integration/helpers_test.go

@@ -369,6 +369,7 @@ func (t *testLogger) Log(ctx context.Context, msg string, fields ...log.Field) {
 
 func (t *testLogger) flush() {
 	t.m.WithLock(func() {
+		t.test.Helper()
 		t.closed = true
 		message := "\n" + strings.Join(t.messages, "\n")
 		t.test.Log(message)

tests/integration/table_regress_test.go renamed to tests/integration/table_regression_test.go

@@ -11,7 +11,9 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
+	"github.com/ydb-platform/ydb-go-genproto/protos/Ydb"
 
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/result"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/result/indexed"
@@ -93,3 +95,21 @@ func TestIssueWideResultWithUnwrap(t *testing.T) {
 		}
 	})
 }
+
+// https://github.com/ydb-platform/ydb-go-sdk/issues/1227
+func TestRegressionIssue1227RetryBadSession(t *testing.T) {
+	var (
+		scope = newScope(t)
+		cnt   = 0
+	)
+	err := scope.Driver().Table().Do(scope.Ctx, func(ctx context.Context, s table.Session) error {
+		cnt++
+		if cnt < 100 {
+			return xerrors.WithStackTrace(xerrors.Operation(xerrors.WithStatusCode(Ydb.StatusIds_BAD_SESSION)))
+		}
+
+		return nil
+	})
+	require.NoError(t, err)
+	require.EqualValues(t, 100, cnt)
+}