Skip to content

Commit e43e5e5

Browse files
authored
Merge pull request #1496 from ydb-platform/fix_query_session_count_metrics
Do not report `query_session_count` metrics when metrics are disabled
2 parents d7525b8 + d5b856c commit e43e5e5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
* Disabled reporting of `ydb_go_sdk_ydb_query_session_create_latency histogram metrics` when metrics are disabled
1+
* Disabled reporting of `ydb_go_sdk_query_session_count` when metrics are disabled
2+
* Disabled reporting of `ydb_go_sdk_ydb_query_session_create_latency` histogram metrics when metrics are disabled
23
* Allowed skip column for `ScanStruct` by tag `-`
34

45
## v3.81.4

metrics/query.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,11 @@ func query(config Config) (t trace.Query) {
134134
errs := deleteConfig.CounterVec("errs", "status")
135135
latency := deleteConfig.TimerVec("latency")
136136
t.OnSessionDelete = func(info trace.QuerySessionDeleteStartInfo) func(info trace.QuerySessionDeleteDoneInfo) {
137-
count.With(nil).Add(-1)
138-
139137
start := time.Now()
140138

141139
return func(info trace.QuerySessionDeleteDoneInfo) {
142140
if deleteConfig.Details()&trace.QuerySessionEvents != 0 {
141+
count.With(nil).Add(-1)
143142
errs.With(map[string]string{
144143
"status": errorBrief(info.Error),
145144
}).Inc()

0 commit comments

Comments
 (0)