Skip to content

Commit e4bf5d6

Browse files
authored
Merge pull request #701 from ydb-platform/slo-native-log-fix
fix: logging nil errors in slo native workers
2 parents 656cad4 + f9f2e4c commit e4bf5d6

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

tests/slo/internal/workers/read.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ func (w *Workers) read(ctx context.Context) (err error) {
2929
m := w.m.Start(metrics.JobRead)
3030
defer func() {
3131
m.Stop(err)
32-
w.logger.Error(fmt.Errorf("get entry error: %w", err).Error())
32+
if err != nil {
33+
w.logger.Error(fmt.Errorf("get entry error: %w", err).Error())
34+
}
3335
}()
3436

3537
_, err = w.s.Read(ctx, id)

tests/slo/internal/workers/write.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ func (w *Workers) write(ctx context.Context, gen *generator.Generator) (err erro
3434
m := w.m.Start(metrics.JobWrite)
3535
defer func() {
3636
m.Stop(err)
37-
w.logger.Error(fmt.Errorf("error when 'write' entry: %w", err).Error())
37+
if err != nil {
38+
w.logger.Error(fmt.Errorf("error when 'write' entry: %w", err).Error())
39+
}
3840
}()
3941

4042
return w.s.Write(ctx, row)

0 commit comments

Comments
 (0)