Merge pull request #1540 from ydb-platform/fix-meta-balancer-init

Fix nil pointer dereference in meta balancer initialization

Author: neyguvj

CHANGELOG.md

@@ -1,3 +1,5 @@
+* Fixed nil pointer dereference in metabalancer initialization
+
 ## v3.89.4
 * Changed behaviour on re-discovery: always open new grpc connection for discovery request
 

driver.go

@@ -351,8 +351,9 @@ func newConnectionFromOptions(ctx context.Context, opts ...Option) (_ *Driver, e
 	}()
 
 	d := &Driver{
-		children:  make(map[uint64]*Driver),
-		ctxCancel: driverCtxCancel,
+		children:     make(map[uint64]*Driver),
+		ctxCancel:    driverCtxCancel,
+		metaBalancer: &balancerWithMeta{},
 	}
 
 	if caFile, has := os.LookupEnv("YDB_SSL_ROOT_CERTIFICATES_FILE"); has {
@@ -436,13 +437,15 @@ func (d *Driver) connect(ctx context.Context) (err error) {
 	if d.pool == nil {
 		d.pool = conn.NewPool(ctx, d.config)
 	}
-	if d.metaBalancer == nil {
+
+	if d.metaBalancer.balancer == nil {
 		b, err := balancer.New(ctx, d.config, d.pool, d.discoveryOptions...)
 		if err != nil {
 			return xerrors.WithStackTrace(err)
 		}
-		d.metaBalancer = &balancerWithMeta{balancer: b, meta: d.config.Meta()}
+		d.metaBalancer.balancer = b
 	}
+	d.metaBalancer.meta = d.config.Meta()
 
 	d.table = xsync.OnceValue(func() (*internalTable.Client, error) {
 		return internalTable.New(xcontext.ValueOnly(ctx),

options.go

@@ -601,7 +601,7 @@ func WithPanicCallback(panicCallback func(e interface{})) Option {
 // WithSharedBalancer sets balancer from parent driver to child driver
 func WithSharedBalancer(parent *Driver) Option {
 	return func(ctx context.Context, d *Driver) error {
-		d.metaBalancer = &balancerWithMeta{balancer: parent.metaBalancer.balancer, meta: d.config.Meta()}
+		d.metaBalancer.balancer = parent.metaBalancer.balancer
 
 		return nil
 	}