Skip to content

Commit ee04de8

Browse files
committed
comments
1 parent 0a77e83 commit ee04de8

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
* Added experimental package `spans` with tracing adapter interfaces for OpenTelemetry, OpenTracing, etc.
12
* Added `db.Topic().DescribeTopicConsumer()` method for displaying consumer information
23
* Marked as deprecated options `ydb.WithDatabase(database)` and `ydb.WithEndpoint(endpoint)`
34

spans/spans.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,13 @@ import (
88
)
99

1010
type (
11+
// KeyValue is key-value attribute for attaching into span
1112
KeyValue = kv.KeyValue
12-
Span interface {
13+
14+
// Span is an interface of spans in specific tracing system
15+
//
16+
// Experimental: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#experimental
17+
Span interface {
1318
TraceID() (_ string, valid bool)
1419

1520
Link(link Span, attributes ...KeyValue)
@@ -20,6 +25,10 @@ type (
2025

2126
End(attributes ...KeyValue)
2227
}
28+
29+
// Adapter is interface of specific tracing system adapters
30+
//
31+
// Experimental: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#experimental
2332
Adapter interface {
2433
trace.Detailer
2534

0 commit comments

Comments
 (0)