Merge pull request #1595 from ydb-platform/fix-session-close-log

asmyasnikov · web-flow · commit ee17f9af8c25 · 2024-12-23T10:47:07.000+03:00
update session status only after logging it
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Fixed an error in logging session deletion events
+
 ## v3.95.3
 * Supported of `database/sql/driver.Valuer` interfaces for params which passed to query using sql driver 
 * Exposed `credentials/credentials.OAuth2Config` OAuth2 config
diff --git a/internal/table/session.go b/internal/table/session.go
@@ -193,8 +193,8 @@ func (s *session) Close(ctx context.Context) (err error) {
 			s,
 		)
 		defer func() {
-			s.SetStatus(table.SessionClosed)
 			onDone(err)
+			s.SetStatus(table.SessionClosed)
 		}()
 
 		if time.Since(s.LastUsage()) < s.config.IdleThreshold() {

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+* Fixed an error in logging session deletion events`
	`2`	`+`
`1`	`3`	`## v3.95.3`
`2`	`4`	* Supported of `database/sql/driver.Valuer` interfaces for params which passed to query using sql driver
`3`	`5`	* Exposed `credentials/credentials.OAuth2Config` OAuth2 config
Original file line number	Diff line number	Diff line change
`@@ -193,8 +193,8 @@ func (s *session) Close(ctx context.Context) (err error) {`
`193`	`193`	`s,`
`194`	`194`	`)`
`195`	`195`	`defer func() {`
`196`		`- s.SetStatus(table.SessionClosed)`
`197`	`196`	`onDone(err)`
	`197`	`+ s.SetStatus(table.SessionClosed)`
`198`	`198`	`}()`
`199`	`199`
`200`	`200`	`if time.Since(s.LastUsage()) < s.config.IdleThreshold() {`