Merge pull request #1410 from ydb-platform/range-func

fixed build tags for range-over

Author: asmyasnikov

.github/workflows/tests.yml

@@ -127,7 +127,6 @@ jobs:
       YDB_SSL_ROOT_CERTIFICATES_FILE: /tmp/ydb_certs/ca.pem
       YDB_SESSIONS_SHUTDOWN_URLS: http://localhost:8765/actors/kqp_proxy?force_shutdown=all
       HIDE_APPLICATION_OUTPUT: 1
-      GOEXPERIMENT: rangefunc
     steps:
       - name: Checkout code
         uses: actions/checkout@v4

CHANGELOG.md

@@ -1,3 +1,5 @@
+* Replaced requirements from go1.22 + experimantal flag to go1.23 for experimental range-over interface
+
 ## v3.76.5
 * Fixed out of index item creation in `internal/pool.Pool`
 * Fixed tracing of `(*grpcClientStream).finish` event

internal/query/result_range_test.go

@@ -1,4 +1,4 @@
-//go:build go1.22 && goexperiment.rangefunc
+//go:build go1.23
 
 package query
 

internal/query/result_set_range_test.go

@@ -1,4 +1,4 @@
-//go:build go1.22 && goexperiment.rangefunc
+//go:build go1.23
 
 package query
 

internal/xiter/xiter.go

@@ -1,4 +1,4 @@
-//go:build !go1.22 || !goexperiment.rangefunc
+//go:build !go1.23
 
 package xiter
 

internal/xiter/xiter_experiment_go1.22.go renamed to internal/xiter/xiter_experiment_go1.23.go

@@ -1,4 +1,4 @@
-//go:build go1.22 && goexperiment.rangefunc
+//go:build go1.23
 
 package xiter
 

query/example_test.go

@@ -1,4 +1,4 @@
-//go:build go1.22 && goexperiment.rangefunc
+//go:build go1.23
 
 package query_test
 
@@ -94,12 +94,12 @@ func Example_rangeExperiment() {
 	if err != nil {
 		panic(err)
 	}
-	// for loop with ResultSets available with Go version 1.22+ and flag `GOEXPERIMENT=rangefunc`.
+	// for loop with ResultSets available with Go version 1.23+
 	for rs, err := range r.ResultSets(ctx) {
 		if err != nil {
 			panic(err)
 		}
-		// for loop with ResultSets available with Go version 1.22+ and flag `GOEXPERIMENT=rangefunc`.
+		// for loop with ResultSets available with Go version 1.23+
 		for row, err := range rs.Rows(ctx) {
 			if err != nil {
 				panic(err)

query/result.go

@@ -18,7 +18,7 @@ type (
 		NextResultSet(ctx context.Context) (ResultSet, error)
 
 		// ResultSets is experimental API for range iterators available
-		// with Go version 1.22+ and flag `GOEXPERIMENT=rangefunc`.
+		// with Go version 1.23+
 		ResultSets(ctx context.Context) xiter.Seq2[ResultSet, error]
 
 		Stats() stats.QueryStats
@@ -29,7 +29,7 @@ type (
 		ColumnTypes() []Type
 		NextRow(ctx context.Context) (Row, error)
 
-		// Rows is experimental API for range iterators available with Go version 1.22+ and flag `GOEXPERIMENT=rangefunc`.
+		// Rows is experimental API for range iterators available with Go version 1.23+
 		Rows(ctx context.Context) xiter.Seq2[Row, error]
 	}
 	Row interface {

tests/integration/query_range_test.go

@@ -1,5 +1,5 @@
-//go:build integration && go1.22 && goexperiment.rangefunc
-// +build integration,go1.22,goexperiment.rangefunc
+//go:build integration && go1.23
+// +build integration,go1.23
 
 package integration