Skip to content

Commit f2fac2e

Browse files
authored
Merge pull request #833 from ydb-platform/placeholder
* Removed support of placeholder "_" for ignoring columns in `databas…
2 parents 688c839 + 7303e0a commit f2fac2e

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
* Removed support of placeholder "_" for ignoring columns in `database/sql` result sets
2+
13
## v3.52.1
24
* Merged `internal/xsql/conn.{GetTables,GetAllTables}` methods for `DRY`
35
* Replaced `internal/xsql.Connector.PathNormalizer` default from `nopPathNormalizer` to `bind.TablePathPrefix` with database name as path prefix

internal/xsql/rows.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ var (
2323
_ driver.Rows = &single{}
2424

2525
_ types.Scanner = &valuer{}
26-
27-
ignoreColumnNamePlaceholder = "_"
2826
)
2927

3028
type rows struct {
@@ -45,9 +43,7 @@ func (r *rows) Columns() []string {
4543
})
4644
cs := make([]string, 0, r.result.CurrentResultSet().ColumnCount())
4745
r.result.CurrentResultSet().Columns(func(m options.Column) {
48-
if m.Name != ignoreColumnNamePlaceholder {
49-
cs = append(cs, m.Name)
50-
}
46+
cs = append(cs, m.Name)
5147
})
5248
return cs
5349
}

0 commit comments

Comments
 (0)