Merge pull request #1176 Default timeout for topic writer connection is infinite

Author: rekby

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Changed default StartTime (time of retries for connect to server) for topic writer from 1 minute to infinite (can be overrided by WithWriterStartTimeout topic option)
 * Added `Struct` support for `Variant` in `ydb.ParamsBuilder()`
 * Added `go` with anonymous function case in `gstack`
 

internal/topic/retriable_error.go

@@ -13,7 +13,7 @@ import (
 )
 
 const (
-	DefaultStartTimeout          = time.Minute
+	DefaultStartTimeout          = value.InfiniteDuration
 	connectionEstablishedTimeout = time.Minute
 )
 

internal/topic/topicwriterinternal/writer_reconnector.go

@@ -380,7 +380,8 @@ func (w *WriterReconnector) connectionLoop(ctx context.Context) {
 		prevAttemptTime = now
 
 		if reconnectReason != nil {
-			if backoff, retry := topic.CheckRetryMode(reconnectReason, w.retrySettings, w.clock.Since(startOfRetries)); retry {
+			retryDuration := w.clock.Since(startOfRetries)
+			if backoff, retry := topic.CheckRetryMode(reconnectReason, w.retrySettings, retryDuration); retry {
 				delay := backoff.Delay(attempt)
 				select {
 				case <-doneCtx:
@@ -389,7 +390,7 @@ func (w *WriterReconnector) connectionLoop(ctx context.Context) {
 					// pass
 				}
 			} else {
-				_ = w.close(ctx, reconnectReason)
+				_ = w.close(ctx, fmt.Errorf("%w, was retried (%v)", reconnectReason, retryDuration))
 
 				return
 			}