Merge pull request #1110 from size12/params-refactoring

tests for .addItems() + .addItems() for set

Author: asmyasnikov

internal/params/list_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/ydb-platform/ydb-go-genproto/protos/Ydb"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/allocator"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/value"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xtest"
 )
 
@@ -639,6 +640,39 @@ func TestList(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:    xtest.CurrentFileLine(),
+			builder: Builder{}.Param("$x").List().AddItems(value.Uint64Value(123), value.Uint64Value(321)).Build(),
+			params: map[string]*Ydb.TypedValue{
+				"$x": {
+					Type: &Ydb.Type{
+						Type: &Ydb.Type_ListType{
+							ListType: &Ydb.ListType{
+								Item: &Ydb.Type{
+									Type: &Ydb.Type_TypeId{
+										TypeId: Ydb.Type_UINT64,
+									},
+								},
+							},
+						},
+					},
+					Value: &Ydb.Value{
+						Items: []*Ydb.Value{
+							{
+								Value: &Ydb.Value_Uint64Value{
+									Uint64Value: 123,
+								},
+							},
+							{
+								Value: &Ydb.Value_Uint64Value{
+									Uint64Value: 321,
+								},
+							},
+						},
+					},
+				},
+			},
+		},
 	} {
 		t.Run(tt.name, func(t *testing.T) {
 			a := allocator.New()

internal/params/set.go

@@ -24,6 +24,12 @@ func (s *set) AddItem() *setItem {
 	}
 }
 
+func (s *set) AddItems(items ...value.Value) *set {
+	s.values = append(s.values, items...)
+
+	return s
+}
+
 func (s *set) Build() Builder {
 	s.parent.params = append(s.parent.params, &Parameter{
 		parent: s.parent,

internal/params/set_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/ydb-platform/ydb-go-genproto/protos/Ydb"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/allocator"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/value"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xtest"
 )
 
@@ -816,6 +817,52 @@ func TestSet(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:    xtest.CurrentFileLine(),
+			builder: Builder{}.Param("$x").Set().AddItems(value.Uint64Value(123), value.Uint64Value(321)).Build(),
+			params: map[string]*Ydb.TypedValue{
+				"$x": {
+					Type: &Ydb.Type{
+						Type: &Ydb.Type_DictType{
+							DictType: &Ydb.DictType{
+								Key: &Ydb.Type{
+									Type: &Ydb.Type_TypeId{
+										TypeId: Ydb.Type_UINT64,
+									},
+								},
+								Payload: &Ydb.Type{
+									Type: &Ydb.Type_VoidType{},
+								},
+							},
+						},
+					},
+					Value: &Ydb.Value{
+						Pairs: []*Ydb.ValuePair{
+							{
+								Key: &Ydb.Value{
+									Value: &Ydb.Value_Uint64Value{
+										Uint64Value: 123,
+									},
+								},
+								Payload: &Ydb.Value{
+									Value: &Ydb.Value_NullFlagValue{},
+								},
+							},
+							{
+								Key: &Ydb.Value{
+									Value: &Ydb.Value_Uint64Value{
+										Uint64Value: 321,
+									},
+								},
+								Payload: &Ydb.Value{
+									Value: &Ydb.Value_NullFlagValue{},
+								},
+							},
+						},
+					},
+				},
+			},
+		},
 	} {
 		t.Run(tt.name, func(t *testing.T) {
 			a := allocator.New()