refactor: linters

Author: ImpressionableRaccoon

.github/workflows/lint.yml

@@ -31,7 +31,6 @@ jobs:
         with:
           version: v1.52.0
           working-directory: tests/slo
-          args: -c ../../.golangci.yml
   autoformatter:
     name: autoformat check
     concurrency:

tests/slo/.golangci.yml

@@ -0,0 +1,241 @@
+# options for analysis running
+run:
+  # default concurrency is a available CPU number
+  concurrency: 4
+
+  # timeout for analysis, e.g. 30s, 5m, default is 1m
+  deadline: 5m
+
+  # exit code when at least one issue was found, default is 1
+  issues-exit-code: 1
+
+  # include test files or not, default is true
+  tests: true
+
+  # list of build tags, all linters use it. Default is empty list.
+  #build-tags:
+  #  - mytag
+
+  # which dirs to skip: they won't be analyzed;
+  # can use regexp here: generated.*, regexp is applied on full path;
+  # default value is empty list, but next dirs are always skipped independently
+  # from this option's value:
+  #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
+  # skip-dirs:
+
+  # which files to skip: they will be analyzed, but issues from them
+  # won't be reported. Default value is empty list, but there is
+  # no need to include all autogenerated files, we confidently recognize
+  # autogenerated files. If it's not please let us know.
+  # skip-files:
+  #    - ".*\\.my\\.go$"
+  #    - lib/bad.go
+
+
+# output configuration options
+output:
+  # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number"
+  format: colored-line-number
+
+  # print lines of code with issue, default is true
+  print-issued-lines: true
+
+  # print linter name in the end of issue text, default is true
+  print-linter-name: true
+
+
+# all available settings of specific linters
+linters-settings:
+  errcheck:
+    # report about not checking of errors in types assetions: `a := b.(MyStruct)`;
+    # default is false: such cases aren't reported by default.
+    check-type-assertions: false
+
+    # report about assignment of errors to blank identifier: `num, _ := strconv.Atoi(numStr)`;
+    # default is false: such cases aren't reported by default.
+    check-blank: false
+  govet:
+    # report about shadowed variables
+    check-shadowing: true
+    fieldalignment: true
+  golint:
+    # minimal confidence for issues, default is 0.8
+    min-confidence: 0.8
+  gofmt:
+    # simplify code: gofmt with `-s` option, true by default
+    simplify: true
+  gofumpt:
+    module-path: slo
+  goimports:
+    # put imports beginning with prefix after 3rd-party packages;
+    # it's a comma-separated list of prefixes
+    local-prefixes: slo
+  goconst:
+    # minimal length of string constant, 3 by default
+    min-len: 2
+    # minimal occurrences count to trigger, 3 by default
+    min-occurrences: 2
+  fieldalignment:
+    # print struct with more effective memory layout or not, false by default
+    suggest-new: true
+  misspell:
+    # Correct spellings using locale preferences for US or UK.
+    # Default is to use a neutral variety of English.
+    # Setting locale to US will correct the British spelling of 'colour' to 'color'.
+    locale: US
+    ignore-words:
+      - cancelled
+  revive:
+    rules:
+      - name: blank-imports
+      - name: context-as-argument
+      - name: context-keys-type
+      - name: dot-imports
+      - name: error-return
+      - name: error-strings
+      - name: error-naming
+      - name: exported
+      - name: if-return
+      - name: increment-decrement
+      - name: var-naming
+      - name: var-declaration
+      - name: package-comments
+      - name: range
+      - name: receiver-naming
+      - name: time-naming
+      - name: indent-error-flow
+      - name: errorf
+      - name: empty-block
+      - name: superfluous-else
+      - name: unreachable-code
+  unused:
+    # treat code as a program (not a library) and report unused exported identifiers; default is false.
+    # XXX: if you enable this setting, unused will report a lot of false-positives in text editors:
+    # if it's called for subdir of a project it can't find funcs usages. All text editor integrations
+    # with golangci-lint call it on a directory with the changed file.
+    check-exported: false
+  unparam:
+    # call graph construction algorithm (cha, rta). In general, use cha for libraries,
+    # and rta for programs with main packages. Default is cha.
+    algo: cha
+
+    # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
+    # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
+    # if it's called for subdir of a project it can't find external interfaces. All text editor integrations
+    # with golangci-lint call it on a directory with the changed file.
+    check-exported: false
+
+linters:
+  disable-all: true
+  enable:
+    #    - cyclop
+    - depguard
+    - dogsled
+    #    - dupl
+    - errcheck
+    - errorlint
+    #    - exhaustive
+    #    - exhaustivestruct
+    #    - forbidigo
+    #    - funlen
+    #    - gci
+    #    - gocognit
+    - goconst
+    - gocritic
+    - gocyclo
+    #    - godot
+    - godox
+    - gofmt # On why gofmt when goimports is enabled - https://github.com/golang/go/issues/21476
+    - gofumpt
+    - goheader
+    - goimports
+    #    - gomnd
+    #    - gomoddirectives
+    #    - gomodguard
+    - gosec
+    - gosimple
+    - govet
+    - depguard
+    #    - ifshort
+    #    - ireturn
+    - lll
+    - makezero
+    - misspell
+    - ineffassign
+    - misspell
+    - nakedret
+    - nestif
+    #    - nilnil
+    #    - nlreturn
+    - nolintlint
+    - prealloc
+    - predeclared
+    - rowserrcheck
+    - revive
+    - staticcheck
+    - stylecheck
+    #    - tagliatelle
+    #    - testpackage
+    #    - thelper
+    #    - tenv
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    #    - varnamelen
+    - whitespace
+#    - wrapcheck
+#    - wsl
+
+issues:
+  # List of regexps of issue texts to exclude, empty list by default.
+  # But independently from this option we use default exclude patterns,
+  # it can be disabled by `exclude-use-default: false`. To list all
+  # excluded by default patterns execute `golangci-lint run --help`
+  # exclude:
+
+  # List of regexps of issue texts to exclude.
+  #
+  # But independently of this option we use default exclude patterns,
+  # it can be disabled by `exclude-use-default: false`.
+  # To list all excluded by default patterns execute `golangci-lint run --help`
+  #
+  # Default: []
+  exclude:
+    - "has been deprecated since Go 1.16"
+
+  # Independently from option `exclude` we use default exclude patterns,
+  # it can be disabled by this option. To list all
+  # excluded by default patterns execute `golangci-lint run --help`.
+  # Default value for this option is true.
+  exclude-use-default: true
+
+  # Maximum issues count per one linter. Set to 0 to disable. Default is 50.
+  max-per-linter: 0
+
+  # Maximum count of issues with the same text. Set to 0 to disable. Default is 3.
+  max-same-issues: 0
+
+  # Show only new issues: if there are unstaged changes or untracked files,
+  # only those changes are analyzed, else only changes in HEAD~ are analyzed.
+  # It's a super-useful option for integration of golangci-lint into existing
+  # large codebase. It's not practical to fix all existing issues at the moment
+  # of integration: much better don't allow issues in new code.
+  # Default is false.
+  new: false
+
+  # Show only new issues created after git revision `REV`
+  # new-from-rev: REV
+
+  # Show only new issues created in git patch with set file path.
+  # new-from-patch: path/to/patch/file
+  exclude-rules:
+    - path: internal/xatomic/type.go
+      linters:
+        - predeclared
+    - path: _test\.go
+      linters:
+        - unused
+        - unparam
+    - path: _test\.go
+      text: "ydb.Connection is deprecated"

tests/slo/internal/generator/generator.go

@@ -29,10 +29,9 @@ func (g *Generator) Generate() (Row, error) {
 	id := g.currentID
 	g.currentID++
 	g.mu.Unlock()
-
 	e := Row{
 		ID:               id,
-		PayloadDouble:    func(a float64) *float64 { return &a }(rand.Float64()),
+		PayloadDouble:    func(a float64) *float64 { return &a }(rand.Float64()), //nolint:gosec // speed more important
 		PayloadTimestamp: func(a uint64) *uint64 { return &a }(uint64(time.Now().UnixMicro())),
 	}
 
@@ -46,7 +45,7 @@ func (g *Generator) Generate() (Row, error) {
 }
 
 func (g *Generator) genPayloadString() (*string, error) {
-	l := MinLength + rand.Intn(MaxLength-MinLength+1)
+	l := MinLength + rand.Intn(MaxLength-MinLength+1) //nolint:gosec // speed more important
 
 	sl := make([]byte, l)
 

tests/slo/internal/workers/read.go

@@ -24,7 +24,7 @@ func (w *Workers) Read(ctx context.Context, wg *sync.WaitGroup, rl *rate.Limiter
 }
 
 func (w *Workers) read(ctx context.Context) (err error) {
-	id := uint64(rand.Intn(int(w.cfg.InitialDataCount)))
+	id := uint64(rand.Intn(int(w.cfg.InitialDataCount))) //nolint:gosec // speed more important
 
 	m := w.m.Start(metrics.JobRead)
 	defer func() {
@@ -34,7 +34,5 @@ func (w *Workers) read(ctx context.Context) (err error) {
 
 	_, err = w.s.Read(ctx, id)
 
-	// todo: check
-
 	return err
 }

tests/slo/native/main.go

@@ -72,7 +72,7 @@ func main() {
 		g := errgroup.Group{}
 
 		for i := uint64(0); i < cfg.InitialDataCount; i++ {
-			g.Go(func() error {
+			g.Go(func() (err error) {
 				e, err := gen.Generate()
 				if err != nil {
 					return err

tests/slo/native/storage.go

@@ -88,8 +88,8 @@ func NewStorage(ctx context.Context, cfg *config.Config, logger *zap.Logger, poo
 	g := errgroup.Group{}
 
 	for i := 0; i < poolSize; i++ {
-		g.Go(func() error {
-			err := s.db.Table().Do(ctx, func(ctx context.Context, s table.Session) error {
+		g.Go(func() (err error) {
+			err = s.db.Table().Do(ctx, func(ctx context.Context, s table.Session) error {
 				return nil
 			})
 			if err != nil {