Merge pull request #366 from ydb-platform/fix-alter-topic

Stop sent empty support codec if customer not set it

Author: asmyasnikov

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Fixed alter topic request - stop send empty setSupportedCodecs if customer not set them 
 * Marked the context errors as required to delete session
 * Added log topic api reader for internal logger
 

internal/grpcwrapper/rawtopic/alter_topic.go

@@ -16,7 +16,8 @@ type AlterTopicRequest struct {
 	AlterPartitionSettings               AlterPartitioningSettings
 	SetRetentionPeriod                   rawoptional.Duration
 	SetRetentionStorageMB                rawoptional.Int64
-	SetSupportedCodecs                   rawtopiccommon.SupportedCodecs
+	SetSupportedCodecs                   bool
+	SetSupportedCodecsValue              rawtopiccommon.SupportedCodecs
 	SetPartitionWriteSpeedBytesPerSecond rawoptional.Int64
 	SetPartitionWriteBurstBytes          rawoptional.Int64
 	AlterAttributes                      map[string]string
@@ -32,12 +33,15 @@ func (req *AlterTopicRequest) ToProto() *Ydb_Topic.AlterTopicRequest {
 		AlterPartitioningSettings:            req.AlterPartitionSettings.ToProto(),
 		SetRetentionPeriod:                   req.SetRetentionPeriod.ToProto(),
 		SetRetentionStorageMb:                req.SetRetentionStorageMB.ToProto(),
-		SetSupportedCodecs:                   req.SetSupportedCodecs.ToProto(),
 		SetPartitionWriteSpeedBytesPerSecond: req.SetPartitionWriteSpeedBytesPerSecond.ToProto(),
 		SetPartitionWriteBurstBytes:          req.SetPartitionWriteBurstBytes.ToProto(),
 		AlterAttributes:                      req.AlterAttributes,
 	}
 
+	if req.SetSupportedCodecs {
+		res.SetSupportedCodecs = req.SetSupportedCodecsValue.ToProto()
+	}
+
 	res.AddConsumers = make([]*Ydb_Topic.Consumer, len(req.AddConsumers))
 	for i := range req.AddConsumers {
 		res.AddConsumers[i] = req.AddConsumers[i].ToProto()

topic/topicoptions/topicoptions_alter.go

@@ -70,9 +70,10 @@ func AlterWithRetentionStorageMB(retentionStorageMB int64) AlterOption {
 // Notice: This API is EXPERIMENTAL and may be changed or removed in a later release.
 func AlterWithSupportedCodecs(codecs ...topictypes.Codec) AlterOption {
 	return func(req *rawtopic.AlterTopicRequest) {
-		req.SetSupportedCodecs = make(rawtopiccommon.SupportedCodecs, len(codecs))
+		req.SetSupportedCodecs = true
+		req.SetSupportedCodecsValue = make(rawtopiccommon.SupportedCodecs, len(codecs))
 		for i, codec := range codecs {
-			req.SetSupportedCodecs[i] = rawtopiccommon.Codec(codec)
+			req.SetSupportedCodecsValue[i] = rawtopiccommon.Codec(codec)
 		}
 	}
 }