feat(TableService): AlterTable now supports index renaming

Author: KirillKurdyukov

table/src/main/java/tech/ydb/table/description/RenameIndex.java

@@ -0,0 +1,29 @@
+package tech.ydb.table.description;
+
+/**
+ * @author Kirill Kurdyukov
+ */
+public class RenameIndex {
+
+    private final String sourceName;
+    private final String destinationName;
+    private final boolean replaceDestination;
+
+    public RenameIndex(String sourceName, String destinationName, boolean replaceDestination) {
+        this.sourceName = sourceName;
+        this.destinationName = destinationName;
+        this.replaceDestination = replaceDestination;
+    }
+
+    public String getSourceName() {
+        return sourceName;
+    }
+
+    public String getDestinationName() {
+        return destinationName;
+    }
+
+    public boolean isReplaceDestination() {
+        return replaceDestination;
+    }
+}

table/src/main/java/tech/ydb/table/impl/BaseSession.java

@@ -45,6 +45,7 @@
 import tech.ydb.table.description.ColumnFamily;
 import tech.ydb.table.description.KeyBound;
 import tech.ydb.table.description.KeyRange;
+import tech.ydb.table.description.RenameIndex;
 import tech.ydb.table.description.StoragePool;
 import tech.ydb.table.description.TableColumn;
 import tech.ydb.table.description.TableDescription;
@@ -567,6 +568,13 @@ public CompletableFuture<Status> alterTable(String path, AlterTableSettings sett
             builder.addDropIndexes(dropIndex);
         }
 
+        for (RenameIndex renameIndex : settings.getRenameIndexes()) {
+            builder.addRenameIndexes(YdbTable.RenameIndexItem.newBuilder()
+                    .setSourceName(renameIndex.getSourceName())
+                    .setDestinationName(renameIndex.getDestinationName())
+                    .setReplaceDestination(renameIndex.isReplaceDestination()).build());
+        }
+
         String traceId = getTraceIdOrGenerateNew(settings.getTraceId());
         final GrpcRequestSettings grpcRequestSettings = makeGrpcRequestSettings(settings.getTimeoutDuration(), traceId);
         return tableRpc.alterTable(builder.build(), grpcRequestSettings);

table/src/main/java/tech/ydb/table/settings/AlterTableSettings.java

@@ -1,5 +1,6 @@
 package tech.ydb.table.settings;
 
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -11,6 +12,7 @@
 
 import javax.annotation.Nullable;
 
+import tech.ydb.table.description.RenameIndex;
 import tech.ydb.table.description.TableColumn;
 import tech.ydb.table.description.TableIndex;
 import tech.ydb.table.description.TableTtl;
@@ -31,6 +33,8 @@ public class AlterTableSettings extends RequestSettings<AlterTableSettings> {
     private final Set<String> dropChangefeeds = new HashSet<>();
     private final Set<String> dropIndexes = new HashSet<>();
 
+    private final List<RenameIndex> renameIndices = new ArrayList<>();
+
     @Nullable
     private TableTtl ttl;
     @Nullable
@@ -111,6 +115,16 @@ public AlterTableSettings addGlobalAsyncIndex(String name, List<String> columns,
         return this;
     }
 
+    public AlterTableSettings addRenameIndex(String oldName, String newName) {
+        renameIndices.add(new RenameIndex(oldName, newName, false));
+        return this;
+    }
+
+    public AlterTableSettings addRenameIndex(String oldName, String newName, boolean replaceExisting) {
+        renameIndices.add(new RenameIndex(oldName, newName, replaceExisting));
+        return this;
+    }
+
     public AlterTableSettings dropIndex(String index) {
         dropIndexes.add(index);
         return this;
@@ -160,6 +174,10 @@ public Collection<String> getDropIndexes() {
         return dropIndexes;
     }
 
+    public Collection<RenameIndex> getRenameIndexes() {
+        return renameIndices;
+    }
+
     @Nullable
     public TableTtl getTableTTL() {
         return ttl;

table/src/test/java/tech/ydb/table/integration/AlterTableTest.java

@@ -51,7 +51,7 @@ public void dropTable() {
 
     @Test
     public void alterTableTest() {
-        // --------------------- craete table -----------------------------
+        // --------------------- create table -----------------------------
         TableDescription createTableDesc = TableDescription.newBuilder()
                 .addNonnullColumn("id", PrimitiveType.Uint64)
                 .addNullableColumn("code", PrimitiveType.Text)
@@ -69,7 +69,7 @@ public void alterTableTest() {
         Assert.assertTrue("Create table with indexes " + createStatus, createStatus.isSuccess());
 
         // --------------------- describe table after creating -----------------------------
-        Result<TableDescription> describeResult = ctx.supplyResult(session ->session.describeTable(tablePath)).join();
+        Result<TableDescription> describeResult = ctx.supplyResult(session -> session.describeTable(tablePath)).join();
         Assert.assertTrue("Describe table with indexes " + describeResult.getStatus(), describeResult.isSuccess());
 
         TableDescription description = describeResult.getValue();
@@ -99,7 +99,7 @@ public void alterTableTest() {
         Assert.assertTrue("Alter table with column " + alterStatus, alterStatus.isSuccess());
 
         // --------------------- describe table after first altering -----------------------------
-        describeResult = ctx.supplyResult(session ->session.describeTable(tablePath)).join();
+        describeResult = ctx.supplyResult(session -> session.describeTable(tablePath)).join();
         Assert.assertTrue("Describe table after altering " + describeResult.getStatus(), describeResult.isSuccess());
 
         description = describeResult.getValue();
@@ -126,7 +126,7 @@ public void alterTableTest() {
         Assert.assertTrue("Alter table with indexes " + alterStatus, alterStatus.isSuccess());
 
         // --------------------- describe table after first altering -----------------------------
-        describeResult = ctx.supplyResult(session ->session.describeTable(tablePath)).join();
+        describeResult = ctx.supplyResult(session -> session.describeTable(tablePath)).join();
         Assert.assertTrue("Describe table after altering " + describeResult.getStatus(), describeResult.isSuccess());
 
         description = describeResult.getValue();
@@ -143,6 +143,20 @@ public void alterTableTest() {
 
         Assert.assertEquals(1, description.getIndexes().size());
         assertIndexAsync(description.getIndexes().get(0), "idx2", Arrays.asList("data"), Arrays.asList("code"));
+
+//        // --------------------- alter table with rename indexes -----------------------------
+//        alterStatus = ctx.supplyStatus(
+//                session -> session.alterTable(tablePath, new AlterTableSettings()
+//                        .addRenameIndex("idx2", "new_name"))
+//        ).join();
+//        Assert.assertTrue("Alter table with rename indexes " + alterStatus, alterStatus.isSuccess());
+//
+//        // --------------------- describe table after rename indexes altering -----------------------------
+//        describeResult = ctx.supplyResult(session -> session.describeTable(tablePath)).join();
+//        Assert.assertTrue("Describe table after altering " + describeResult.getStatus(), describeResult.isSuccess());
+//
+//        Assert.assertEquals(1, description.getIndexes().size());
+//        assertIndexAsync(description.getIndexes().get(0), "new_name", Arrays.asList("data"), Arrays.asList("code"));
     }
 
     private void assertColumn(TableColumn column, String name, Type type) {