Remove equals/hashCode implementations. Will create a separate PR for these changes

Daniil Zulin · Daniil Zulin · commit 1ca0b668ecca · 2025-05-07T15:56:12.000+07:00
diff --git a/topic/src/main/java/tech/ydb/topic/description/Consumer.java b/topic/src/main/java/tech/ydb/topic/description/Consumer.java
@@ -5,7 +5,6 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Objects;
 import java.util.stream.Collectors;
 
 import javax.annotation.Nonnull;
@@ -141,23 +140,4 @@ public Consumer build() {
             return new Consumer(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        Consumer consumer = (Consumer) o;
-        return important == consumer.important &&
-                Objects.equals(name, consumer.name) &&
-                Objects.equals(readFrom, consumer.readFrom) &&
-                Objects.equals(supportedCodecs, consumer.supportedCodecs) &&
-                Objects.equals(attributes, consumer.attributes) &&
-                Objects.equals(stats, consumer.stats);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(name, important, readFrom, supportedCodecs, attributes, stats);
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/ConsumerDescription.java b/topic/src/main/java/tech/ydb/topic/description/ConsumerDescription.java
@@ -2,7 +2,6 @@
 
 
 import java.util.List;
-import java.util.Objects;
 import java.util.stream.Collectors;
 
 import tech.ydb.proto.topic.YdbTopic;
@@ -29,18 +28,4 @@ public Consumer getConsumer() {
     public List<ConsumerPartitionInfo> getPartitions() {
         return partitions;
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        ConsumerDescription that = (ConsumerDescription) o;
-        return Objects.equals(consumer, that.consumer) && Objects.equals(partitions, that.partitions);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(consumer, partitions);
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/ConsumerPartitionInfo.java b/topic/src/main/java/tech/ydb/topic/description/ConsumerPartitionInfo.java
@@ -3,7 +3,6 @@
 import java.time.Duration;
 import java.time.Instant;
 import java.util.List;
-import java.util.Objects;
 
 import tech.ydb.core.utils.ProtobufUtils;
 import tech.ydb.proto.topic.YdbTopic;
@@ -179,32 +178,4 @@ public int getConnectionNodeId() {
             return connectionNodeId;
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        ConsumerPartitionInfo that = (ConsumerPartitionInfo) o;
-        return partitionId == that.partitionId &&
-                active == that.active &&
-                Objects.equals(childPartitionIds, that.childPartitionIds) &&
-                Objects.equals(parentPartitionIds, that.parentPartitionIds) &&
-                Objects.equals(partitionStats, that.partitionStats) &&
-                Objects.equals(consumerStats, that.consumerStats) &&
-                Objects.equals(location, that.location);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(
-                partitionId,
-                active,
-                childPartitionIds,
-                parentPartitionIds,
-                partitionStats,
-                consumerStats,
-                location
-        );
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/PartitionInfo.java b/topic/src/main/java/tech/ydb/topic/description/PartitionInfo.java
@@ -2,7 +2,6 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Objects;
 
 import com.google.common.collect.ImmutableList;
 
@@ -87,22 +86,4 @@ public PartitionInfo build() {
             return new PartitionInfo(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        PartitionInfo that = (PartitionInfo) o;
-        return partitionId == that.partitionId &&
-                active == that.active &&
-                Objects.equals(childPartitionIds, that.childPartitionIds) &&
-                Objects.equals(parentPartitionIds, that.parentPartitionIds) &&
-                Objects.equals(partitionStats, that.partitionStats);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(partitionId, active, childPartitionIds, parentPartitionIds, partitionStats);
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/PartitionStats.java b/topic/src/main/java/tech/ydb/topic/description/PartitionStats.java
@@ -2,7 +2,6 @@
 
 import java.time.Duration;
 import java.time.Instant;
-import java.util.Objects;
 
 import javax.annotation.Nullable;
 
@@ -127,30 +126,4 @@ public PartitionStats build() {
             return new PartitionStats(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        PartitionStats that = (PartitionStats) o;
-        return storeSizeBytes == that.storeSizeBytes &&
-                partitionNodeId == that.partitionNodeId &&
-                Objects.equals(partitionOffsets, that.partitionOffsets) &&
-                Objects.equals(lastWriteTime, that.lastWriteTime) &&
-                Objects.equals(maxWriteTimeLag, that.maxWriteTimeLag) &&
-                Objects.equals(bytesWritten, that.bytesWritten);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(
-                partitionOffsets,
-                storeSizeBytes,
-                lastWriteTime,
-                maxWriteTimeLag,
-                bytesWritten,
-                partitionNodeId
-        );
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/SupportedCodecs.java b/topic/src/main/java/tech/ydb/topic/description/SupportedCodecs.java
@@ -2,7 +2,6 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Objects;
 
 import com.google.common.collect.ImmutableList;
 
@@ -48,18 +47,4 @@ public SupportedCodecs build() {
             return new SupportedCodecs(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        SupportedCodecs that = (SupportedCodecs) o;
-        return Objects.equals(codecs, that.codecs);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hashCode(codecs);
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/TopicDescription.java b/topic/src/main/java/tech/ydb/topic/description/TopicDescription.java
@@ -4,7 +4,6 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
-import java.util.Objects;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -180,40 +179,4 @@ public TopicDescription build() {
             return new TopicDescription(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        TopicDescription that = (TopicDescription) o;
-        return retentionStorageMb == that.retentionStorageMb &&
-                partitionWriteSpeedBytesPerSecond == that.partitionWriteSpeedBytesPerSecond &&
-                partitionWriteBurstBytes == that.partitionWriteBurstBytes &&
-                Objects.equals(partitioningSettings, that.partitioningSettings) &&
-                Objects.equals(partitions, that.partitions) &&
-                Objects.equals(retentionPeriod, that.retentionPeriod) &&
-                Objects.equals(supportedCodecs, that.supportedCodecs) &&
-                Objects.equals(attributes, that.attributes) &&
-                Objects.equals(consumers, that.consumers) &&
-                meteringMode == that.meteringMode &&
-                Objects.equals(topicStats, that.topicStats);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(
-                partitioningSettings,
-                partitions,
-                retentionPeriod,
-                retentionStorageMb,
-                supportedCodecs,
-                partitionWriteSpeedBytesPerSecond,
-                partitionWriteBurstBytes,
-                attributes,
-                consumers,
-                meteringMode,
-                topicStats
-        );
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/TopicStats.java b/topic/src/main/java/tech/ydb/topic/description/TopicStats.java
@@ -2,7 +2,6 @@
 
 import java.time.Duration;
 import java.time.Instant;
-import java.util.Objects;
 
 import javax.annotation.Nullable;
 
@@ -77,21 +76,4 @@ public TopicStats build() {
             return new TopicStats(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        TopicStats that = (TopicStats) o;
-        return storeSizeBytes == that.storeSizeBytes &&
-                Objects.equals(minLastWriteTime, that.minLastWriteTime) &&
-                Objects.equals(maxWriteTimeLag, that.maxWriteTimeLag) &&
-                Objects.equals(bytesWritten, that.bytesWritten);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(storeSizeBytes, minLastWriteTime, maxWriteTimeLag, bytesWritten);
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/settings/AutoPartitioningWriteStrategySettings.java b/topic/src/main/java/tech/ydb/topic/settings/AutoPartitioningWriteStrategySettings.java
@@ -1,7 +1,6 @@
 package tech.ydb.topic.settings;
 
 import java.time.Duration;
-import java.util.Objects;
 
 public class AutoPartitioningWriteStrategySettings {
     private final Duration stabilizationWindow;
@@ -70,20 +69,4 @@ public AutoPartitioningWriteStrategySettings build() {
             return new AutoPartitioningWriteStrategySettings(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        AutoPartitioningWriteStrategySettings that = (AutoPartitioningWriteStrategySettings) o;
-        return upUtilizationPercent == that.upUtilizationPercent &&
-                downUtilizationPercent == that.downUtilizationPercent &&
-                Objects.equals(stabilizationWindow, that.stabilizationWindow);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(stabilizationWindow, upUtilizationPercent, downUtilizationPercent);
-    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/settings/PartitioningSettings.java b/topic/src/main/java/tech/ydb/topic/settings/PartitioningSettings.java
@@ -1,7 +1,5 @@
 package tech.ydb.topic.settings;
 
-import java.util.Objects;
-
 /**
  * @author Nikolay Perfilov
  */
@@ -109,21 +107,4 @@ public PartitioningSettings build() {
             return new PartitioningSettings(this);
         }
     }
-
-    @Override
-    public boolean equals(Object o) {
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        PartitioningSettings that = (PartitioningSettings) o;
-        return minActivePartitions == that.minActivePartitions &&
-                partitionCountLimit == that.partitionCountLimit &&
-                autoPartitioningStrategy == that.autoPartitioningStrategy &&
-                Objects.equals(writeStrategySettings, that.writeStrategySettings);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(minActivePartitions, partitionCountLimit, autoPartitioningStrategy, writeStrategySettings);
-    }
 }
