Add test for alter topic

Daniil Zulin · Daniil Zulin · commit 32aaae35e63e · 2025-05-06T20:49:35.000+07:00
Add equals implementations for topic description classes
diff --git a/tests/common/src/main/java/tech/ydb/test/integration/YdbEnvironment.java b/tests/common/src/main/java/tech/ydb/test/integration/YdbEnvironment.java
@@ -9,7 +9,7 @@
  * @author Aleksandr Gorshenin
  */
 public class YdbEnvironment {
-    private static final String YDB_DEFAULT_IMAGE = "ydbplatform/local-ydb:latest";
+    private static final String YDB_DEFAULT_IMAGE = "ydbplatform/local-ydb:25.1";
 
     private final Supplier<String> ydbEndpoint = createParam("YDB_ENDPOINT", null);
     private final Supplier<String> ydbDatabase = createParam("YDB_DATABASE", null);
diff --git a/topic/src/main/java/tech/ydb/topic/description/Consumer.java b/topic/src/main/java/tech/ydb/topic/description/Consumer.java
@@ -5,6 +5,7 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.stream.Collectors;
 
 import javax.annotation.Nonnull;
@@ -140,4 +141,21 @@ public Consumer build() {
             return new Consumer(this);
         }
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        Consumer consumer = (Consumer) o;
+        return important == consumer.important &&
+                Objects.equals(name, consumer.name) &&
+                Objects.equals(readFrom, consumer.readFrom) &&
+                Objects.equals(supportedCodecs, consumer.supportedCodecs) &&
+                Objects.equals(attributes, consumer.attributes) &&
+                Objects.equals(stats, consumer.stats);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(name, important, readFrom, supportedCodecs, attributes, stats);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/ConsumerDescription.java b/topic/src/main/java/tech/ydb/topic/description/ConsumerDescription.java
@@ -2,6 +2,7 @@
 
 
 import java.util.List;
+import java.util.Objects;
 import java.util.stream.Collectors;
 
 import tech.ydb.proto.topic.YdbTopic;
@@ -29,4 +30,15 @@ public List<ConsumerPartitionInfo> getPartitions() {
         return partitions;
     }
 
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        ConsumerDescription that = (ConsumerDescription) o;
+        return Objects.equals(consumer, that.consumer) && Objects.equals(partitions, that.partitions);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(consumer, partitions);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/ConsumerPartitionInfo.java b/topic/src/main/java/tech/ydb/topic/description/ConsumerPartitionInfo.java
@@ -3,6 +3,7 @@
 import java.time.Duration;
 import java.time.Instant;
 import java.util.List;
+import java.util.Objects;
 
 import tech.ydb.core.utils.ProtobufUtils;
 import tech.ydb.proto.topic.YdbTopic;
@@ -178,4 +179,22 @@ public int getConnectionNodeId() {
             return connectionNodeId;
         }
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        ConsumerPartitionInfo that = (ConsumerPartitionInfo) o;
+        return partitionId == that.partitionId &&
+                active == that.active &&
+                Objects.equals(childPartitionIds, that.childPartitionIds) &&
+                Objects.equals(parentPartitionIds, that.parentPartitionIds) &&
+                Objects.equals(partitionStats, that.partitionStats) &&
+                Objects.equals(consumerStats, that.consumerStats) &&
+                Objects.equals(location, that.location);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(partitionId, active, childPartitionIds, parentPartitionIds, partitionStats, consumerStats, location);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/MultipleWindowsStat.java b/topic/src/main/java/tech/ydb/topic/description/MultipleWindowsStat.java
@@ -2,6 +2,8 @@
 
 import tech.ydb.proto.topic.YdbTopic;
 
+import java.util.Objects;
+
 /**
  * @author Nikolay Perfilov
  */
@@ -33,4 +35,16 @@ public long getPerHour() {
     public long getPerDay() {
         return perDay;
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        MultipleWindowsStat that = (MultipleWindowsStat) o;
+        return perMinute == that.perMinute && perHour == that.perHour && perDay == that.perDay;
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(perMinute, perHour, perDay);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/PartitionInfo.java b/topic/src/main/java/tech/ydb/topic/description/PartitionInfo.java
@@ -2,6 +2,7 @@
 
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
 
 import com.google.common.collect.ImmutableList;
 
@@ -86,4 +87,20 @@ public PartitionInfo build() {
             return new PartitionInfo(this);
         }
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        PartitionInfo that = (PartitionInfo) o;
+        return partitionId == that.partitionId &&
+                active == that.active &&
+                Objects.equals(childPartitionIds, that.childPartitionIds) &&
+                Objects.equals(parentPartitionIds, that.parentPartitionIds) &&
+                Objects.equals(partitionStats, that.partitionStats);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(partitionId, active, childPartitionIds, parentPartitionIds, partitionStats);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/PartitionStats.java b/topic/src/main/java/tech/ydb/topic/description/PartitionStats.java
@@ -2,6 +2,7 @@
 
 import java.time.Duration;
 import java.time.Instant;
+import java.util.Objects;
 
 import javax.annotation.Nullable;
 
@@ -126,4 +127,21 @@ public PartitionStats build() {
             return new PartitionStats(this);
         }
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        PartitionStats that = (PartitionStats) o;
+        return storeSizeBytes == that.storeSizeBytes &&
+                partitionNodeId == that.partitionNodeId &&
+                Objects.equals(partitionOffsets, that.partitionOffsets) &&
+                Objects.equals(lastWriteTime, that.lastWriteTime) &&
+                Objects.equals(maxWriteTimeLag, that.maxWriteTimeLag) &&
+                Objects.equals(bytesWritten, that.bytesWritten);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(partitionOffsets, storeSizeBytes, lastWriteTime, maxWriteTimeLag, bytesWritten, partitionNodeId);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/SupportedCodecs.java b/topic/src/main/java/tech/ydb/topic/description/SupportedCodecs.java
@@ -2,6 +2,7 @@
 
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
 
 import com.google.common.collect.ImmutableList;
 
@@ -47,4 +48,16 @@ public SupportedCodecs build() {
             return new SupportedCodecs(this);
         }
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        SupportedCodecs that = (SupportedCodecs) o;
+        return Objects.equals(codecs, that.codecs);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hashCode(codecs);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/TopicDescription.java b/topic/src/main/java/tech/ydb/topic/description/TopicDescription.java
@@ -4,6 +4,7 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -180,4 +181,25 @@ public TopicDescription build() {
         }
     }
 
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        TopicDescription that = (TopicDescription) o;
+        return retentionStorageMb == that.retentionStorageMb &&
+                partitionWriteSpeedBytesPerSecond == that.partitionWriteSpeedBytesPerSecond &&
+                partitionWriteBurstBytes == that.partitionWriteBurstBytes &&
+                Objects.equals(partitioningSettings, that.partitioningSettings) &&
+                Objects.equals(partitions, that.partitions) &&
+                Objects.equals(retentionPeriod, that.retentionPeriod) &&
+                Objects.equals(supportedCodecs, that.supportedCodecs) &&
+                Objects.equals(attributes, that.attributes) &&
+                Objects.equals(consumers, that.consumers) &&
+                meteringMode == that.meteringMode &&
+                Objects.equals(topicStats, that.topicStats);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(partitioningSettings, partitions, retentionPeriod, retentionStorageMb, supportedCodecs, partitionWriteSpeedBytesPerSecond, partitionWriteBurstBytes, attributes, consumers, meteringMode, topicStats);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/description/TopicStats.java b/topic/src/main/java/tech/ydb/topic/description/TopicStats.java
@@ -2,6 +2,7 @@
 
 import java.time.Duration;
 import java.time.Instant;
+import java.util.Objects;
 
 import javax.annotation.Nullable;
 
@@ -76,4 +77,19 @@ public TopicStats build() {
             return new TopicStats(this);
         }
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        TopicStats that = (TopicStats) o;
+        return storeSizeBytes == that.storeSizeBytes &&
+                Objects.equals(minLastWriteTime, that.minLastWriteTime) &&
+                Objects.equals(maxWriteTimeLag, that.maxWriteTimeLag) &&
+                Objects.equals(bytesWritten, that.bytesWritten);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(storeSizeBytes, minLastWriteTime, maxWriteTimeLag, bytesWritten);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/OffsetsRangeImpl.java b/topic/src/main/java/tech/ydb/topic/read/impl/OffsetsRangeImpl.java
@@ -2,6 +2,8 @@
 
 import tech.ydb.topic.description.OffsetsRange;
 
+import java.util.Objects;
+
 /**
  * @author Nikolay Perfilov
  */
@@ -36,4 +38,16 @@ public void setStart(long start) {
     public void setEnd(long end) {
         this.end = end;
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        OffsetsRangeImpl that = (OffsetsRangeImpl) o;
+        return start == that.start && end == that.end;
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(start, end);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/settings/AlterAutoPartitioningWriteStrategySettings.java b/topic/src/main/java/tech/ydb/topic/settings/AlterAutoPartitioningWriteStrategySettings.java
@@ -4,7 +4,6 @@
 
 import java.time.Duration;
 
-// TODO add proper javadocs
 public class AlterAutoPartitioningWriteStrategySettings {
     @Nullable
     private final Duration stabilizationWindow;
@@ -44,7 +43,8 @@ public static class Builder {
         private Integer downUtilizationPercent = null;
 
         /**
-         * @param stabilizationWindow
+         * @param stabilizationWindow       Duration used by the auto partitioning algorithm to define if the partition must be split.
+         *                                  Default value is 5 minutes.
          * @return strategy builder
          */
         public Builder setStabilizationWindow(Duration stabilizationWindow) {
@@ -53,7 +53,8 @@ public Builder setStabilizationWindow(Duration stabilizationWindow) {
         }
 
         /**
-         * @param upUtilizationPercent
+         * @param upUtilizationPercent      Upper level of partition quota utilization after which the partition should be split.
+         *                                  Default value is 90%.
          * @return strategy builder
          */
         public Builder setUpUtilizationPercent(int upUtilizationPercent) {
@@ -62,7 +63,9 @@ public Builder setUpUtilizationPercent(int upUtilizationPercent) {
         }
 
         /**
-         * @param downUtilizationPercent
+         * @param downUtilizationPercent    Lower level of partition quota utilization
+         *                                  after which the partition should be merged with the other one.
+         *                                  Default value is 30%.
          * @return strategy builder
          */
         public Builder setDownUtilizationPercent(int downUtilizationPercent) {
diff --git a/topic/src/main/java/tech/ydb/topic/settings/AutoPartitioningWriteStrategySettings.java b/topic/src/main/java/tech/ydb/topic/settings/AutoPartitioningWriteStrategySettings.java
@@ -1,6 +1,7 @@
 package tech.ydb.topic.settings;
 
 import java.time.Duration;
+import java.util.Objects;
 
 public class AutoPartitioningWriteStrategySettings {
     private final Duration stabilizationWindow;
@@ -35,7 +36,8 @@ public static class Builder {
         private int downUtilizationPercent = 30;
 
         /**
-         * @param stabilizationWindow
+         * @param stabilizationWindow       Duration used by the auto partitioning algorithm to define if the partition must be split.
+         *                                  Default value is 5 minutes.
          * @return strategy builder
          */
         public Builder setStabilizationWindow(Duration stabilizationWindow) {
@@ -44,7 +46,8 @@ public Builder setStabilizationWindow(Duration stabilizationWindow) {
         }
 
         /**
-         * @param upUtilizationPercent
+         * @param upUtilizationPercent      Upper level of partition quota utilization after which the partition should be split.
+         *                                  Default value is 90%.
          * @return strategy builder
          */
         public Builder setUpUtilizationPercent(int upUtilizationPercent) {
@@ -53,7 +56,9 @@ public Builder setUpUtilizationPercent(int upUtilizationPercent) {
         }
 
         /**
-         * @param downUtilizationPercent
+         * @param downUtilizationPercent    Lower level of partition quota utilization
+         *                                  after which the partition should be merged with the other one.
+         *                                  Default value is 30%.
          * @return strategy builder
          */
         public Builder setDownUtilizationPercent(int downUtilizationPercent) {
@@ -65,4 +70,18 @@ public AutoPartitioningWriteStrategySettings build() {
             return new AutoPartitioningWriteStrategySettings(this);
         }
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;
+        AutoPartitioningWriteStrategySettings that = (AutoPartitioningWriteStrategySettings) o;
+        return upUtilizationPercent == that.upUtilizationPercent &&
+                downUtilizationPercent == that.downUtilizationPercent &&
+                Objects.equals(stabilizationWindow, that.stabilizationWindow);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(stabilizationWindow, upUtilizationPercent, downUtilizationPercent);
+    }
 }
diff --git a/topic/src/main/java/tech/ydb/topic/settings/PartitioningSettings.java b/topic/src/main/java/tech/ydb/topic/settings/PartitioningSettings.java
diff --git a/topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java b/topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java
