Added preferReady option to Topic's commitOffset method

alex268 · alex268 · commit 6ca4c372e692 · 2025-12-09T12:18:09.000Z
diff --git a/topic/src/main/java/tech/ydb/topic/impl/TopicClientImpl.java b/topic/src/main/java/tech/ydb/topic/impl/TopicClientImpl.java
@@ -401,7 +401,10 @@ public CompletableFuture<Status> commitOffset(String path, CommitOffsetSettings
             request.setReadSessionId(settings.getReadSessionId());
         }
 
-        final GrpcRequestSettings grpcRequestSettings = makeGrpcRequestSettings(settings);
+        GrpcRequestSettings grpcRequestSettings = GrpcRequestSettings.newBuilder()
+                .withDeadline(settings.getRequestTimeout())
+                .withPreferReadyChannel(true)
+                .build();
         return topicRpc.commitOffset(request.build(), grpcRequestSettings);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -401,7 +401,10 @@ public CompletableFuture<Status> commitOffset(String path, CommitOffsetSettings`
`401`	`401`	`request.setReadSessionId(settings.getReadSessionId());`
`402`	`402`	`}`
`403`	`403`
`404`		`- final GrpcRequestSettings grpcRequestSettings = makeGrpcRequestSettings(settings);`
	`404`	`+ GrpcRequestSettings grpcRequestSettings = GrpcRequestSettings.newBuilder()`
	`405`	`+ .withDeadline(settings.getRequestTimeout())`
	`406`	`+ .withPreferReadyChannel(true)`
	`407`	`+ .build();`
`405`	`408`	`return topicRpc.commitOffset(request.build(), grpcRequestSettings);`
`406`	`409`	`}`
`407`	`410`