New tests

Author: alex268

common/src/main/java/tech/ydb/common/retry/RetryConfig.java

@@ -1,5 +1,6 @@
 package tech.ydb.common.retry;
 
+
 import tech.ydb.core.Status;
 import tech.ydb.core.UnexpectedResultException;
 
@@ -15,10 +16,10 @@ public interface RetryConfig {
     /**
      * Returns retry policy for the given {@link Status} and {@code null} if that status is not retryable
      *
-     * @param code status to check
+     * @param status status to check
      * @return policy of retries or {@code null} if the status is not retryable
      */
-    RetryPolicy getStatusRetryPolicy(Status code);
+    RetryPolicy getStatusRetryPolicy(Status status);
 
     /**
      * Returns retry policy for the given exception and {@code null} if that exception is not retryable
@@ -36,7 +37,7 @@ default RetryPolicy getThrowableRetryPolicy(Throwable th) {
     }
 
     /**
-     * Infinity retries with default exponential delay.<br>That policy <b>does not</b> retries <i>conditionally</i>
+     * Infinity retries with default exponential delay.<br>This policy <b>does not</b> retries <i>conditionally</i>
      * retryable errors so it can be used for both as idempotent and non idempotent operations
      *
      * @return retry configuration object
@@ -46,7 +47,7 @@ static RetryConfig retryForever() {
     }
 
     /**
-     * Retries until the specified elapsed milliseconds expire.<br>That policy <b>does not</b> retries
+     * Retries until the specified elapsed milliseconds expire.<br>This policy <b>does not</b> retries
      * <i>conditionally</i> retryable errors so it can be used for both as idempotent and non idempotent operations
      * @param maxElapsedMs maximum timeout for retries
      * @return retry configuration object
@@ -56,7 +57,7 @@ static RetryConfig retryUntilElapsed(long maxElapsedMs) {
     }
 
     /**
-     * Infinity retries with default exponential delay.<br>That policy <b>does</b> retries <i>conditionally</i>
+     * Infinity retries with default exponential delay.<br>This policy <b>does</b> retries <i>conditionally</i>
      * retryable errors so it can be used <b>ONLY</b> for idempotent operations
      * @return retry configuration object
      */
@@ -65,7 +66,7 @@ static RetryConfig idempotentRetryForever() {
     }
 
     /**
-     * Retries until the specified elapsed milliseconds expire.<br>That policy <b>does</b> retries
+     * Retries until the specified elapsed milliseconds expire.<br>This policy <b>does</b> retries
      * <i>conditionally</i> retryable errors so it can be used <b>ONLY</b> for idempotent operations
      * @param maxElapsedMs maximum timeout for retries
      * @return retry configuration object

common/src/test/java/tech/ydb/common/transaction/impl/YdbTransactionImplTest.java

@@ -32,4 +32,15 @@ public void baseTest() {
         Assert.assertTrue(tx.isActive());
         Assert.assertFalse(tx.getStatusFuture().isDone());
     }
+
+    @Test
+    public void nullTest() {
+        MockTx tx = new MockTx(TxMode.NONE, null);
+
+        Assert.assertNull(tx.getId());
+        Assert.assertEquals("MOCK", tx.getSessionId());
+        Assert.assertEquals(TxMode.NONE, tx.getTxMode());
+        Assert.assertFalse(tx.isActive());
+        Assert.assertFalse(tx.getStatusFuture().isDone());
+    }
 }

topic/src/test/java/tech/ydb/topic/impl/BaseMockedTest.java

@@ -164,6 +164,13 @@ public void responseErrorBadRequest() {
             observer.onNext(msg);
         }
 
+        public void responseErrorSchemeError() {
+            YdbTopic.StreamWriteMessage.FromServer msg = YdbTopic.StreamWriteMessage.FromServer.newBuilder()
+                    .setStatus(StatusCodesProtos.StatusIds.StatusCode.SCHEME_ERROR)
+                    .build();
+            observer.onNext(msg);
+        }
+
         public void responseInit(long lastSeqNo) {
             responseInit(lastSeqNo, 123, "mocked", new int[] { 0, 1, 2});
         }
@@ -205,23 +212,27 @@ public Checker(YdbTopic.StreamWriteMessage.FromClient msg) {
             }
 
             public Checker isInit() {
-                Assert.assertTrue(msg.hasInitRequest());
+                Assert.assertTrue("next msg must be init request", msg.hasInitRequest());
                 return this;
             }
 
             public Checker hasInitPath(String path) {
-                Assert.assertEquals(path, msg.getInitRequest().getPath());
+                Assert.assertEquals("invalid init request path", path, msg.getInitRequest().getPath());
                 return this;
             }
 
             public Checker isWrite() {
-                Assert.assertTrue(msg.hasWriteRequest());
+                Assert.assertTrue("next msg must be write request", msg.hasWriteRequest());
                 return this;
             }
 
-            public Checker hasWrite(int codec, int messagesCount) {
-                Assert.assertEquals(codec, msg.getWriteRequest().getCodec());
-                Assert.assertEquals(messagesCount, msg.getWriteRequest().getMessagesCount());
+            public Checker hasWrite(int codec, long... seqnums) {
+                Assert.assertEquals("invalid write codec", codec, msg.getWriteRequest().getCodec());
+                Assert.assertEquals("invalid messages count", seqnums.length, msg.getWriteRequest().getMessagesCount());
+                for (int idx = 0; idx < seqnums.length; idx++) {
+                    Assert.assertEquals("invalid msg seqNo " + idx, seqnums[idx],
+                            msg.getWriteRequest().getMessages(idx).getSeqNo());
+                }
                 return this;
             }
         }