Fix memory leak in retry loop caused by AbortSignal.any()

Replace `AbortSignal.any()` with `linkSignals` from
`@ydbjs/abortable@^6.1.0`, which properly cleans up event listeners
using `Symbol.dispose`.

Also fix signal handling in `setTimeout` and correct the order of
error/attempt updates in the catch block.

Signed-off-by: Vladislav Polyakov <polRk@ydb.tech>

Author: polRk

.changeset/pswbdeilqd.md

@@ -0,0 +1,14 @@
+---
+'@ydbjs/retry': minor
+---
+
+Fix memory leak in retry loop caused by `AbortSignal.any()`
+
+`AbortSignal.any()` registers event listeners on all source signals but never removes them, leading to a listener leak on every retry attempt. Replace it with `linkSignals` from `@ydbjs/abortable@^6.1.0`, which uses `Symbol.dispose` to clean up listeners immediately after each attempt via `using`.
+
+Additional correctness fixes in the same loop:
+
+- Fix order of `ctx.error` / `ctx.attempt` updates so error is recorded before incrementing attempt counter
+- Rename local `retry` variable to `willRetry` to avoid shadowing the outer function name
+- Pass the composed `signal` (instead of raw `cfg.signal`) to `setTimeout` so abort is properly respected during the inter-attempt delay
+- Fix oxlint directive from `disable` to `disable-next-line` to suppress only the intended line

package-lock.json

@@ -48,7 +48,7 @@
 		"attw": "attw --pack --profile esm-only"
 	},
 	"dependencies": {
-		"@ydbjs/abortable": "^6.0.0",
+		"@ydbjs/abortable": "^6.1.0",
 		"@ydbjs/api": "^6.0.0",
 		"@ydbjs/debug": "^6.0.0",
 		"@ydbjs/error": "^6.0.0",

packages/retry/package.json

@@ -1,6 +1,6 @@
 import { setTimeout } from 'timers/promises'
 
-import { abortable } from '@ydbjs/abortable'
+import { abortable, linkSignals } from '@ydbjs/abortable'
 import { StatusIds_StatusCode } from '@ydbjs/api/operation'
 import { loggers } from '@ydbjs/debug'
 import { CommitError, YDBError } from '@ydbjs/error'
@@ -34,20 +34,21 @@ export async function retry<R>(
 		(budget = typeof config.budget === 'number' ? config.budget : config.budget!(ctx, config))
 	) {
 		let ac = new AbortController()
-		let signal = cfg.signal ? AbortSignal.any([cfg.signal, ac.signal]) : ac.signal
+		using linkedSignal = linkSignals(cfg.signal, ac.signal)
 
 		let start = Date.now()
+		let signal = linkedSignal.signal
 
 		try {
 			signal.throwIfAborted()
 			dbg.log('attempt %d: calling retry function', ctx.attempt + 1)
-			// oxlint-disable no-await-in-loop
+			// oxlint-disable-next-line no-await-in-loop
 			let result = await abortable(signal, Promise.resolve(fn(signal)))
 			dbg.log('attempt %d: success', ctx.attempt + 1)
 			return result
 		} catch (error) {
-			ctx.attempt += 1
 			ctx.error = error
+			ctx.attempt += 1
 
 			if (error instanceof Error && error.name === 'AbortError') {
 				dbg.log('attempt %d: abort error, not retryable', ctx.attempt)
@@ -59,14 +60,14 @@ export async function retry<R>(
 				throw error
 			}
 
-			let retry: boolean
+			let willRetry: boolean
 			if (typeof config.retry === 'boolean') {
-				retry = config.retry
+				willRetry = config.retry
 			} else {
-				retry = config.retry?.(ctx.error, cfg.idempotent ?? false) ?? false
+				willRetry = config.retry?.(ctx.error, cfg.idempotent ?? false) ?? false
 			}
 
-			if (!retry || ctx.attempt >= budget) {
+			if (!willRetry || ctx.attempt >= budget) {
 				dbg.log('attempt %d: not retrying, error: %O', ctx.attempt, error)
 				break
 			}
@@ -86,7 +87,7 @@ export async function retry<R>(
 
 			dbg.log('attempt %d: waiting %d ms before next retry', ctx.attempt, remaining)
 			// oxlint-disable no-await-in-loop
-			await setTimeout(remaining, void 0, { signal: cfg.signal })
+			await setTimeout(remaining, void 0, { signal })
 
 			if (config.onRetry) {
 				config.onRetry(ctx)