Skip to content

Commit 073ed86

Browse files
committed
fix nodeset labels
1 parent f21e08e commit 073ed86

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

internal/resources/database_statefulset.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ func (b *DatabaseStatefulSetBuilder) buildPodTemplateLabels() labels.Labels {
9292
podTemplateLabels := labels.Labels{}
9393

9494
podTemplateLabels.Merge(b.Labels)
95-
podTemplateLabels.Merge(b.Spec.AdditionalPodLabels)
9695
podTemplateLabels.Merge(map[string]string{labels.StatefulsetComponent: b.Name})
96+
podTemplateLabels.Merge(b.Spec.AdditionalPodLabels)
9797

9898
return podTemplateLabels
9999
}

internal/resources/databasenodeset.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (b *DatabaseNodeSetBuilder) Placeholder(cr client.Object) client.Object {
5555
}
5656

5757
func (b *DatabaseNodeSetResource) buildLabels() labels.Labels {
58-
l := labels.Common(b.Name, b.Labels)
58+
l := labels.Common(b.Spec.DatabaseRef.Name, b.Labels)
5959
l.Merge(b.Spec.AdditionalLabels)
6060
l.Merge(map[string]string{labels.ComponentKey: labels.DynamicComponent})
6161
if nodeSetName, exist := b.Labels[labels.DatabaseNodeSetComponent]; exist {
@@ -70,12 +70,9 @@ func (b *DatabaseNodeSetResource) buildLabels() labels.Labels {
7070

7171
func (b *DatabaseNodeSetResource) GetResourceBuilders(restConfig *rest.Config) []ResourceBuilder {
7272
ydbCr := api.RecastDatabaseNodeSet(b.Unwrap())
73-
databaseNodeSetLabels := b.buildLabels()
74-
7573
statefulSetName := b.Name
76-
statefulSetLabels := databaseNodeSetLabels.Copy()
77-
statefulSetLabels.Merge(map[string]string{labels.StatefulsetComponent: statefulSetName})
7874

75+
statefulSetLabels := b.buildLabels()
7976
statefulSetAnnotations := CopyDict(b.Spec.AdditionalAnnotations)
8077
statefulSetAnnotations[annotations.ConfigurationChecksum] = GetConfigurationChecksum(b.Spec.Configuration)
8178

internal/resources/storage_statefulset.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ func (b *StorageStatefulSetBuilder) buildPodTemplateLabels() labels.Labels {
107107
podTemplateLabels := labels.Labels{}
108108

109109
podTemplateLabels.Merge(b.Labels)
110-
podTemplateLabels.Merge(b.Spec.AdditionalPodLabels)
111110
podTemplateLabels.Merge(map[string]string{labels.StatefulsetComponent: b.Name})
111+
podTemplateLabels.Merge(b.Spec.AdditionalPodLabels)
112112

113113
return podTemplateLabels
114114
}

internal/resources/storagenodeset.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ func (b *StorageNodeSetBuilder) Placeholder(cr client.Object) client.Object {
5555
}
5656

5757
func (b *StorageNodeSetResource) buildLabels() labels.Labels {
58-
l := labels.Common(b.Name, b.Labels)
58+
l := labels.Common(b.Spec.StorageRef.Name, b.Labels)
5959
l.Merge(b.Spec.AdditionalLabels)
60-
l.Merge(map[string]string{labels.ComponentKey: labels.DynamicComponent})
60+
l.Merge(map[string]string{labels.ComponentKey: labels.StorageComponent})
6161
if nodeSetName, exist := b.Labels[labels.StorageNodeSetComponent]; exist {
6262
l.Merge(map[string]string{labels.StorageNodeSetComponent: nodeSetName})
6363
}
@@ -70,12 +70,9 @@ func (b *StorageNodeSetResource) buildLabels() labels.Labels {
7070

7171
func (b *StorageNodeSetResource) GetResourceBuilders(restConfig *rest.Config) []ResourceBuilder {
7272
ydbCr := api.RecastStorageNodeSet(b.Unwrap())
73-
storageNodeSetLabels := b.buildLabels()
7473

7574
statefulSetName := b.Name
76-
statefulSetLabels := storageNodeSetLabels.Copy()
77-
statefulSetLabels.Merge(map[string]string{labels.StatefulsetComponent: statefulSetName})
78-
75+
statefulSetLabels := b.buildLabels()
7976
statefulSetAnnotations := CopyDict(b.Spec.AdditionalAnnotations)
8077
statefulSetAnnotations[annotations.ConfigurationChecksum] = GetConfigurationChecksum(b.Spec.Configuration)
8178

0 commit comments

Comments
 (0)