extract defaultCapabilities to variable

nikitka · nikitka · commit 1ddd5d736315 · 2024-12-25T13:12:20.000+01:00
diff --git a/internal/resources/security_context.go b/internal/resources/security_context.go
@@ -17,6 +17,7 @@ func contains(s []corev1.Capability, v corev1.Capability) bool {
 
 func mergeSecurityContextWithDefaults(context *corev1.SecurityContext) *corev1.SecurityContext {
 	var result *corev1.SecurityContext
+	var defaultCapabilities = []corev1.Capability{"SYS_RAWIO"}
 
 	if context != nil {
 		result = context.DeepCopy()
@@ -36,7 +37,7 @@ func mergeSecurityContextWithDefaults(context *corev1.SecurityContext) *corev1.S
 		}
 	}
 
-	for _, defaultCapability := range []corev1.Capability{"SYS_RAWIO"} {
+	for _, defaultCapability := range defaultCapabilities {
 		if !contains(result.Capabilities.Add, defaultCapability) {
 			result.Capabilities.Add = append(result.Capabilities.Add, defaultCapability)
 		}

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ func contains(s []corev1.Capability, v corev1.Capability) bool {`
`17`	`17`
`18`	`18`	`func mergeSecurityContextWithDefaults(context corev1.SecurityContext) corev1.SecurityContext {`
`19`	`19`	`var result *corev1.SecurityContext`
	`20`	`+ var defaultCapabilities = []corev1.Capability{"SYS_RAWIO"}`
`20`	`21`
`21`	`22`	`if context != nil {`
`22`	`23`	`result = context.DeepCopy()`
`@@ -36,7 +37,7 @@ func mergeSecurityContextWithDefaults(context corev1.SecurityContext) corev1.S`
`36`	`37`	`}`
`37`	`38`	`}`
`38`	`39`
`39`		`- for _, defaultCapability := range []corev1.Capability{"SYS_RAWIO"} {`
	`40`	`+ for _, defaultCapability := range defaultCapabilities {`
`40`	`41`	`if !contains(result.Capabilities.Add, defaultCapability) {`
`41`	`42`	`result.Capabilities.Add = append(result.Capabilities.Add, defaultCapability)`
`42`	`43`	`}`