fix: golangci-lint working again

Author: Jorres

.github/workflows/run-tests.yml

@@ -12,15 +12,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v3
-      - name: setup-go
-        uses: actions/setup-go@v3
-        with:
-          go-version: '1.20'
+        uses: actions/checkout@v4
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.58.1
+          version: v1.61.0
   run-unit-tests:
     concurrency:
       group: run-unit-tests-${{ github.head_ref || github.ref_name }}

.golangci.yml

@@ -56,7 +56,7 @@ linters-settings:
     check-blank: false
   govet:
     # report about shadowed variables
-    check-shadowing: true
+    shadow: true
     fieldalignment: true
   golint:
     # minimal confidence for issues, default is 0.8
@@ -76,6 +76,7 @@ linters-settings:
   gosec:
     excludes:
      - G101
+     - G115
   fieldalignment:
     # print struct with more effective memory layout or not, false by default
     suggest-new: true
@@ -129,6 +130,8 @@ linters-settings:
 linters:
   disable-all: true
   enable:
+#    - cyclop
+    # - depguardgolang
     - dogsled
     - errcheck
     - errorlint

internal/exec/exec.go

@@ -58,6 +58,7 @@ func InPod(
 	if err != nil {
 		return stdout.String(), stderr.String(), errors.Wrapf(
 			err,
+			//nolint:govet  // TODO @jorres figure out why non-const error messages are not recommended
 			fmt.Sprintf("failed to stream execution results back, stdout:\n\"%s\"stderr:\n\"%s\"", stdout.String(), stderr.String()),
 		)
 	}