fixes pointers

Author: kobzonega

internal/annotations/annotations.go

@@ -8,7 +8,7 @@ const (
 	RemoteResourceVersionAnnotation   = "ydb.tech/remote-resource-version"
 	ConfigurationChecksum             = "ydb.tech/configuration-checksum"
 	RemoteFinalizerKey                = "ydb.tech/remote-finalizer"
-	LastApplied                       = "ydb.tech/last-applied"
+	LastAppliedAnnotation             = "ydb.tech/last-applied"
 )
 
 func GetYdbTechAnnotations(annotations map[string]string) map[string]string {
@@ -23,7 +23,7 @@ func GetYdbTechAnnotations(annotations map[string]string) map[string]string {
 
 func GetLastAppliedAnnotation(annotations map[string]string) string {
 	for key, value := range annotations {
-		if key == LastApplied {
+		if key == LastAppliedAnnotation {
 			return value
 		}
 	}

internal/controllers/storage/controller_test.go

@@ -126,6 +126,9 @@ var _ = Describe("Storage controller medium tests", func() {
 				foundConfigurationChecksumAnnotation = true
 			}
 			Expect(foundConfigurationChecksumAnnotation).To(BeTrue())
+
+			_, exist := podAnnotations[annotations.LastAppliedAnnotation]
+			Expect(exist).To(BeFalse())
 		})
 
 		By("Check that args with --label propagated to pods...", func() {

internal/resources/database.go

@@ -46,7 +46,7 @@ func (b *DatabaseBuilder) NewAnnotations() map[string]string {
 		an[k] = v
 	}
 	an[annotations.ConfigurationChecksum] = GetSHA256Checksum(b.Spec.Configuration)
-	delete(an, annotations.LastApplied)
+	delete(an, annotations.LastAppliedAnnotation)
 	return an
 }
 

internal/resources/resource.go

@@ -85,7 +85,7 @@ type ResourceBuilder interface {
 }
 
 var (
-	annotator  = patch.NewAnnotator(ydbannotations.LastApplied)
+	annotator  = patch.NewAnnotator(ydbannotations.LastAppliedAnnotation)
 	patchMaker = patch.NewPatchMaker(annotator)
 )
 

internal/resources/storage.go

@@ -46,7 +46,7 @@ func (b *StorageClusterBuilder) NewAnnotations() map[string]string {
 		an[k] = v
 	}
 	an[annotations.ConfigurationChecksum] = GetSHA256Checksum(b.Spec.Configuration)
-	delete(an, annotations.LastApplied)
+	delete(an, annotations.LastAppliedAnnotation)
 	return an
 }
 

internal/resources/storage_statefulset.go

@@ -69,7 +69,7 @@ func (b *StorageStatefulSetBuilder) Build(obj client.Object) error {
 	sts.Spec = appsv1.StatefulSetSpec{
 		Replicas: replicas,
 		Selector: &metav1.LabelSelector{
-			MatchLabels: b.Labels,
+			MatchLabels: CopyDict(b.Labels),
 		},
 		PodManagementPolicy:  appsv1.ParallelPodManagement,
 		RevisionHistoryLimit: ptr.Int32(10),
@@ -107,8 +107,8 @@ func (b *StorageStatefulSetBuilder) buildPodTemplateSpec() corev1.PodTemplateSpe
 
 	podTemplate := corev1.PodTemplateSpec{
 		ObjectMeta: metav1.ObjectMeta{
-			Labels:      b.Labels,
-			Annotations: b.Annotations,
+			Labels:      CopyDict(b.Labels),
+			Annotations: CopyDict(b.Annotations),
 		},
 		Spec: corev1.PodSpec{
 			Containers:                    []corev1.Container{b.buildContainer()},