Release docker image to dockerhub as well (#259)

Jorres · web-flow · commit 8cc391ac7134 · 2024-11-13T23:04:59.000+01:00
diff --git a/.changes/unreleased/Added-20241113-181628.yaml b/.changes/unreleased/Added-20241113-181628.yaml
@@ -0,0 +1,3 @@
+kind: Added
+body: starting with this release, deploying to dockerhub (ydbplatform/ydb-kubernetes-operator)
+time: 2024-11-13T18:16:28.275365313+01:00
diff --git a/.changes/unreleased/Fixed-20241113-214512.yaml b/.changes/unreleased/Fixed-20241113-214512.yaml
@@ -0,0 +1,3 @@
+kind: Fixed
+body: e2e tests and unit tests flapped because of the race between storage finalizers and uninstalling operator helm chart
+time: 2024-11-13T21:45:12.19273022+01:00
diff --git a/.github/workflows/upload-artifacts.yml b/.github/workflows/upload-artifacts.yml
@@ -67,6 +67,7 @@ jobs:
         # Public:
         docker build -t cr.yandex/crpl7ipeu79oseqhcgn2/ydb-operator:"$VERSION" .
         docker push cr.yandex/crpl7ipeu79oseqhcgn2/ydb-operator:"$VERSION"
+
         # Private:
         # no rebuild will happen, docker will fetch from cache and just retag:
         docker build -t cr.yandex/crpsjg1coh47p81vh2lc/ydb-kubernetes-operator:"$VERSION" .
@@ -95,6 +96,16 @@ jobs:
         aws s3 --endpoint-url=https://storage.yandexcloud.net \
           cp ./charts/index.yaml s3://charts.ydb.tech/index.yaml
 
+    - name: login-to-dockerhub
+      uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
+      with:
+        username: ydbplatform
+        password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
+    - name: retag-and-push-operator-image-to-dockerhub
+      run: |
+        docker build -t ydbplatform/ydb-kubernetes-operator:"$VERSION" .
+        docker push ydbplatform/ydb-kubernetes-operator:"$VERSION"
+
     - name: append-artifacts-info-to-release-notes
       run: |
         echo "" >> .changes/v$VERSION.md
diff --git a/.golangci.yml b/.golangci.yml
@@ -4,7 +4,7 @@ run:
   concurrency: 4
 
   # timeout for analysis, e.g. 30s, 5m, default is 1m
-  deadline: 5m
+  timeout: 5m
 
   # exit code when at least one issue was found, default is 1
   issues-exit-code: 1
diff --git a/e2e/tests/smoke_test.go b/e2e/tests/smoke_test.go
@@ -146,6 +146,22 @@ func checkPodsRunningAndReady(ctx context.Context, podLabelKey, podLabelValue st
 	}, test.Timeout, test.Interval).Should(BeTrue())
 }
 
+func deleteStorageSafely(ctx context.Context, storageSample *v1alpha1.Storage) {
+	// not checking that deletion completed successfully
+	// because some tests delete storage themselves and
+	// it may already be deleted.
+	_ = k8sClient.Delete(ctx, storageSample)
+
+	Eventually(func() bool {
+		fetched := v1alpha1.Storage{}
+		err := k8sClient.Get(ctx, types.NamespacedName{
+			Name:      storageSample.Name,
+			Namespace: testobjects.YdbNamespace,
+		}, &fetched)
+		return apierrors.IsNotFound(err)
+	}, Timeout, Interval).Should(BeTrue())
+}
+
 func bringYdbCliToPod(podName, podNamespace string) {
 	Eventually(func(g Gomega) error {
 		args := []string{
@@ -305,9 +321,7 @@ var _ = Describe("Operator smoke test", func() {
 	It("Check webhook defaulter", func() {
 		emptyStorageDefaultFields(storageSample)
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		emptyDatabaseDefaultFields(databaseSample)
 		Expect(k8sClient.Create(ctx, databaseSample)).Should(Succeed())
@@ -330,17 +344,13 @@ var _ = Describe("Operator smoke test", func() {
 			},
 		}
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 	})
 
 	It("general smoke pipeline, create storage + database", func() {
 		By("issuing create commands...")
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 		Expect(k8sClient.Create(ctx, databaseSample)).Should(Succeed())
 		defer func() {
 			Expect(k8sClient.Delete(ctx, databaseSample)).Should(Succeed())
@@ -381,9 +391,7 @@ var _ = Describe("Operator smoke test", func() {
 	It("pause and un-pause Storage, should destroy and bring up Pods", func() {
 		By("issuing create commands...")
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		By("waiting until Storage is ready...")
 		waitUntilStorageReady(ctx, storageSample.Name, testobjects.YdbNamespace)
@@ -431,9 +439,7 @@ var _ = Describe("Operator smoke test", func() {
 	It("freeze + delete StatefulSet + un-freeze Storage", func() {
 		By("issuing create commands...")
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		By("waiting until Storage is ready...")
 		waitUntilStorageReady(ctx, storageSample.Name, testobjects.YdbNamespace)
@@ -503,20 +509,6 @@ var _ = Describe("Operator smoke test", func() {
 
 		By("checking that all the storage pods are running and ready...")
 		checkPodsRunningAndReady(ctx, "ydb-cluster", "kind-storage", storageSample.Spec.Nodes)
-
-		/*
-			// This test suite attempts to create a database on uninitialised storage
-
-			By("database can be healthily created after Frozen storage...")
-			Expect(k8sClient.Create(ctx, databaseSample)).Should(Succeed())
-			defer func() {
-				Expect(k8sClient.Delete(ctx, databaseSample)).Should(Succeed())
-			}()
-			By("waiting until database is ready...")
-			waitUntilDatabaseReady(ctx, databaseSample.Name, testobjects.YdbNamespace)
-			By("checking that all the database pods are running and ready...")
-			checkPodsRunningAndReady(ctx, "ydb-cluster", "kind-database", databaseSample.Spec.Nodes)
-		*/
 	})
 
 	It("create storage and database with nodeSets", func() {
@@ -538,9 +530,7 @@ var _ = Describe("Operator smoke test", func() {
 			})
 		}
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 		Expect(k8sClient.Create(ctx, databaseSample)).Should(Succeed())
 		defer func() {
 			Expect(k8sClient.Delete(ctx, databaseSample)).Should(Succeed())
@@ -619,9 +609,7 @@ var _ = Describe("Operator smoke test", func() {
 			},
 		}
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		By("waiting until Storage is ready...")
 		waitUntilStorageReady(ctx, storageSample.Name, testobjects.YdbNamespace)
@@ -632,9 +620,7 @@ var _ = Describe("Operator smoke test", func() {
 
 	It("storage.State goes Pending -> Preparing -> Initializing -> Provisioning -> Ready", func() {
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		By("waiting until Storage is ready...")
 		waitUntilStorageReady(ctx, storageSample.Name, testobjects.YdbNamespace)
@@ -688,9 +674,7 @@ var _ = Describe("Operator smoke test", func() {
 			Key:                  "ca.crt",
 		}
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		By("waiting until Storage is ready...")
 		waitUntilStorageReady(ctx, storageSample.Name, testobjects.YdbNamespace)
@@ -742,6 +726,7 @@ var _ = Describe("Operator smoke test", func() {
 	It("Check that Storage deleted after Database...", func() {
 		By("create storage...")
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
+		defer deleteStorageSafely(ctx, storageSample)
 
 		By("create database...")
 		Expect(k8sClient.Create(ctx, databaseSample)).Should(Succeed())
@@ -803,9 +788,7 @@ var _ = Describe("Operator smoke test", func() {
 		storageSample = testobjects.DefaultStorage(filepath.Join(".", "data", "storage-mirror-3-dc-dynconfig.yaml"))
 
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		storage := v1alpha1.Storage{}
 		By("waiting until StorageInitialized condition is true...")
@@ -919,9 +902,7 @@ var _ = Describe("Operator smoke test", func() {
 			},
 		}
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 
 		By("create database...")
 		databaseSample.Spec.Nodes = 1
@@ -959,9 +940,7 @@ var _ = Describe("Operator smoke test", func() {
 	It("Check encryption for Database", func() {
 		By("create storage...")
 		Expect(k8sClient.Create(ctx, storageSample)).Should(Succeed())
-		defer func() {
-			Expect(k8sClient.Delete(ctx, storageSample)).Should(Succeed())
-		}()
+		defer deleteStorageSafely(ctx, storageSample)
 		By("create database...")
 		databaseSample.Spec.Encryption = &v1alpha1.EncryptionConfig{
 			Enabled: true,
diff --git a/internal/controllers/database/controller_test.go b/internal/controllers/database/controller_test.go
@@ -56,6 +56,7 @@ func TestAPIs(t *testing.T) {
 var _ = Describe("Database controller medium tests", func() {
 	var namespace corev1.Namespace
 	var storageSample v1alpha1.Storage
+	var databaseSample v1alpha1.Database
 
 	BeforeEach(func() {
 		namespace = corev1.Namespace{
@@ -94,14 +95,15 @@ var _ = Describe("Database controller medium tests", func() {
 	})
 
 	AfterEach(func() {
+		Expect(k8sClient.Delete(ctx, &databaseSample)).Should(Succeed())
 		Expect(k8sClient.Delete(ctx, &storageSample)).Should(Succeed())
 		Expect(k8sClient.Delete(ctx, &namespace)).Should(Succeed())
 		test.DeleteAllObjects(env, k8sClient, &namespace)
 	})
 
 	It("Checking field propagation to objects", func() {
 		By("Check that Shared Database was created...")
-		databaseSample := *testobjects.DefaultDatabase()
+		databaseSample = *testobjects.DefaultDatabase()
 		databaseSample.Spec.SharedResources = &v1alpha1.DatabaseResources{
 			StorageUnits: []v1alpha1.StorageUnit{
 				{

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+kind: Added`
	`2`	`+body: starting with this release, deploying to dockerhub (ydbplatform/ydb-kubernetes-operator)`
	`3`	`+time: 2024-11-13T18:16:28.275365313+01:00`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+kind: Fixed`
	`2`	`+body: e2e tests and unit tests flapped because of the race between storage finalizers and uninstalling operator helm chart`
	`3`	`+time: 2024-11-13T21:45:12.19273022+01:00`