fix panic on GetHostFromConfigEndpoint

Author: kobzonega

api/v1alpha1/configuration.go

@@ -122,12 +122,23 @@ func BuildConfiguration(cr *Storage, crDB *Database) ([]byte, error) {
 	return yaml.Marshal(config)
 }
 
-func ParseConfig(rawYamlConfiguration string) (schema.Configuration, error) {
-	config := schema.Configuration{}
+func ParseConfiguration(rawYamlConfiguration string) (schema.Configuration, error) {
+	configuration := schema.Configuration{}
+
+	dynconfig, err := ParseDynconfig(rawYamlConfiguration)
+	if err == nil {
+		config, err := yaml.Marshal(dynconfig.Config)
+		if err != nil {
+			return configuration, err
+		}
+		rawYamlConfiguration = string(config)
+	}
+
 	dec := yaml.NewDecoder(bytes.NewReader([]byte(rawYamlConfiguration)))
 	dec.KnownFields(false)
-	err := dec.Decode(&config)
-	return config, err
+	err = dec.Decode(&configuration)
+
+	return configuration, err
 }
 
 func ParseDynconfig(rawYamlConfiguration string) (schema.Dynconfig, error) {

api/v1alpha1/storage_webhook.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
-	"gopkg.in/yaml.v3"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/utils/strings/slices"
@@ -62,15 +61,12 @@ func (r *Storage) GetGRPCServiceEndpoint() string {
 }
 
 func (r *Storage) GetHostFromConfigEndpoint() string {
-	configuration := make(map[string]interface{})
+	var configuration schema.Configuration
 
 	// skip handle error because we already checked in webhook
-	_ = yaml.Unmarshal([]byte(r.Spec.Configuration), &configuration)
-	hostsConfig := configuration["hosts"].([]schema.Host)
-
-	randNum := rand.Int31n(r.Spec.Nodes) // #nosec G404
-	host := hostsConfig[randNum].Host
-	return fmt.Sprintf("%s:%d", host, GRPCPort)
+	configuration, _ = ParseConfiguration(r.Spec.Configuration)
+	randNum := rand.Intn(len(configuration.Hosts)) // #nosec G404
+	return fmt.Sprintf("%s:%d", configuration.Hosts[randNum].Host, GRPCPort)
 }
 
 func (r *Storage) IsStorageEndpointSecure() bool {
@@ -181,19 +177,9 @@ func (r *Storage) ValidateCreate() error {
 
 	var configuration schema.Configuration
 
-	rawYamlConfiguration := r.Spec.Configuration
-	dynconfig, err := ParseDynconfig(r.Spec.Configuration)
-	if err == nil {
-		config, err := yaml.Marshal(dynconfig.Config)
-		if err != nil {
-			return fmt.Errorf("failed to parse .config from dynconfig, error: %w", err)
-		}
-		rawYamlConfiguration = string(config)
-	}
-
-	configuration, err = ParseConfig(rawYamlConfiguration)
+	configuration, err := ParseConfiguration(r.Spec.Configuration)
 	if err != nil {
-		return fmt.Errorf("failed to parse .spec.configuration, error: %w", err)
+		return fmt.Errorf("failed to parse configuration, error: %w", err)
 	}
 
 	var nodesNumber int32
@@ -278,21 +264,9 @@ func hasUpdatesBesidesFrozen(oldStorage, newStorage *Storage) (bool, string) {
 func (r *Storage) ValidateUpdate(old runtime.Object) error {
 	storagelog.Info("validate update", "name", r.Name)
 
-	var configuration schema.Configuration
-
-	rawYamlConfiguration := r.Spec.Configuration
-	dynconfig, err := ParseDynconfig(r.Spec.Configuration)
-	if err == nil {
-		config, err := yaml.Marshal(dynconfig.Config)
-		if err != nil {
-			return fmt.Errorf("failed to parse .config from dynconfig, error: %w", err)
-		}
-		rawYamlConfiguration = string(config)
-	}
-
-	configuration, err = ParseConfig(rawYamlConfiguration)
+	configuration, err := ParseConfiguration(r.Spec.Configuration)
 	if err != nil {
-		return fmt.Errorf("failed to parse .spec.configuration, error: %w", err)
+		return fmt.Errorf("failed to parse configuration, error: %w", err)
 	}
 
 	var nodesNumber int32

deploy/ydb-operator/Chart.yaml

@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.5.16
+version: 0.5.17
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.5.16"
+appVersion: "0.5.17"

internal/configuration/schema/schema_test.go

@@ -122,8 +122,8 @@ var _ = Describe("Testing schema", func() {
 		Expect(err).Should(HaveOccurred())
 	})
 
-	It("Parse static config", func() {
-		yamlConfig, err := v1alpha1.ParseConfig(configurationExample)
+	It("Parse configuration with static config", func() {
+		yamlConfig, err := v1alpha1.ParseConfiguration(configurationExample)
 		Expect(err).ShouldNot(HaveOccurred())
 		hosts := []schema.Host{}
 		for i := 0; i < 8; i++ {
@@ -149,4 +149,9 @@ var _ = Describe("Testing schema", func() {
 			},
 		}))
 	})
+
+	It("Parse configuration with dynamic config", func() {
+		_, err := v1alpha1.ParseConfiguration(dynconfigExample)
+		Expect(err).ShouldNot(HaveOccurred())
+	})
 })