Publich python package CI #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package’s CI/CD and versioning strategy while streamlining version management. Key changes include:
- Introducing a dedicated version file and autoversion support through pyproject.toml.
- Removing setup.py in favor of pyproject.toml and updating package dependencies.
- Adding a GitHub Actions workflow for publishing package releases and an incremental version script.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ydb_mcp/version.py | New version constant defined. |
| ydb_mcp/init.py | Updated to import VERSION from version.py and set version. |
| setup.py | Removed setup.py in favor of modern packaging with pyproject.toml. |
| pyproject.toml | Updated metadata, version, and dependency requirements. |
| CHANGELOG.md | Initial changelog added. |
| .github/workflows/python-publish.yml | New release workflow; note the Python version setup. |
| .github/scripts/increment_version.py | Added version increment script with autoversion support. |
Comments suppressed due to low confidence (1)
.github/scripts/increment_version.py:27
- [nitpick] The class declares an attribute 'patch' but uses 'micro' when assigning the patch version. Consider using consistent naming (either 'patch' or 'micro') for clarity.
self.micro = version.micro
| - name: Set up Python | ||
| uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: '3.9' |
There was a problem hiding this comment.
The workflow is configured to use Python 3.9, but pyproject.toml requires Python >=3.10. Consider updating the workflow to use a compatible Python version.
Suggested change
| python-version: '3.9' | |
| python-version: '3.10' |
blinkov
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.