Change linters to Ruff and add CI job #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvoleg
force-pushed
the
enable_linters
branch
7 times, most recently
from
c7af464 to
fd8c2a2
Compare
vgvoleg
force-pushed
the
enable_linters
branch
2 times, most recently
from
9ca48be to
0e05ac4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the linter configuration to use Ruff and adds a CI job to run linters, alongside a few minor code formatting and type hint improvements. Key changes include:
- Adding a runtime check for a missing session pool in QueryExecutor.
- Updating type hints using the union operator (|) for better clarity.
- Adjusting formatting and simplifying expressions in tests and CI configurations.
Reviewed Changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ydb_mcp/query.py | Added a session pool check and updated type hints. |
| ydb_mcp/connection.py | Minor type hint update and string literal adjustments. |
| ydb_mcp/main.py | Removed unneeded f-string for a literal output. |
| ydb_mcp/init.py | Minor reordering of import statements. |
| tests/* | Various formatting improvements and minor cleanup. |
| pyproject.toml | Updated dependencies versions and switched to Ruff config. |
| .github/workflows/* | Added new workflow files for linters and tests. |
| .github/scripts/increment_version.py | Minor formatting adjustments. |
Files not reviewed (2)
- Makefile: Language not supported
- requirements-dev.txt: Language not supported
blinkov
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.