review fixes

Author: vgvoleg

tests/slo/src/jobs.py

@@ -31,17 +31,6 @@
 );
 """
 
-# QUERY_READ_QUERY_TEMPLATE = """
-# SELECT * FROM `{}` WHERE object_id = $object_id AND object_hash = Digest::NumericHash($object_id);
-# """
-
-# QUERY_WRITE_QUERY_TEMPLATE = """
-# UPSERT INTO `{}` (
-#     object_id, object_hash, payload_str, payload_double, payload_timestamp
-# ) VALUES (
-#     $object_id, Digest::NumericHash($object_id), $payload_str, $payload_double, $payload_timestamp
-# );
-# """
 
 logger = logging.getLogger(__name__)
 
@@ -286,6 +275,7 @@ def run_writes_query(driver, query, row_generator, metrics, limiter, runtime, ti
             }
 
             def check_result(result):
+                # we have to close stream by reading it till the end
                 with result:
                     pass
 

tests/slo/src/metrics.py

@@ -14,7 +14,6 @@
 JOB_STATUS_OK, JOB_STATUS_ERR = "ok", "err"
 
 SDK_SERVICE_NAME = environ.get("SDK_SERVICE", "sync-python-table")
-print(f"SDK_SERVICE_NAME = {SDK_SERVICE_NAME}")
 
 
 class Metrics:

tests/slo/src/runner.py

@@ -109,7 +109,7 @@ def run_slo(args, driver, tb_name):
     for future in futures:
         future.join()
 
-    # metrics.reset()
+    metrics.reset()
 
 
 def run_cleanup(args, driver, tb_name):