Skip to content

Commit 9b746fc

Browse files
committed
typo while check reconnector_id and style
1 parent 9e0e44d commit 9b746fc

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

ydb/_topic_common/test_helpers.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,11 @@ async def wait_condition(
5454
if timeout is None:
5555
timeout = 1
5656

57+
minimal_loop_count_for_wait = 1000
58+
5759
start = time.monotonic()
5860
counter = 0
59-
while (time.monotonic() - start < timeout) or counter < 1000:
61+
while (time.monotonic() - start < timeout) or counter < minimal_loop_count_for_wait:
6062
counter += 1
6163
if f():
6264
return

ydb/_topic_reader/topic_reader_asyncio.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -361,10 +361,7 @@ def commit(
361361
) -> datatypes.PartitionSession.CommitAckWaiter:
362362
partition_session = batch._commit_get_partition_session()
363363

364-
if (
365-
partition_session.reader_reconnector_id
366-
!= partition_session.reader_reconnector_id
367-
):
364+
if partition_session.reader_reconnector_id != self._reader_reconnector_id:
368365
raise TopicReaderError("reader can commit only self-produced messages")
369366

370367
if partition_session.reader_stream_id != self._id:
@@ -498,11 +495,8 @@ def _on_read_response(self, message: StreamReadMessage.ReadResponse):
498495

499496
def _on_commit_response(self, message: StreamReadMessage.CommitOffsetResponse):
500497
for partition_offset in message.partitions_committed_offsets:
501-
try:
502-
session = self._partition_sessions[
503-
partition_offset.partition_session_id
504-
]
505-
except KeyError:
498+
session = self._partition_sessions.get(partition_offset.partition_session_id)
499+
if session is None:
506500
continue
507501
session.ack_notify(partition_offset.committed_offset)
508502

0 commit comments

Comments
 (0)