Skip to content

Commit e58371e

Browse files
committed
Revert "wait top stop background tasks before stop writer stream"
This reverts commit ecc8cbc.
1 parent ecc8cbc commit e58371e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

ydb/_topic_writer/topic_writer_asyncio.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,8 @@ async def _connection_loop(self):
366366

367367
tasks = [send_loop, receive_loop]
368368
done, _ = await asyncio.wait([send_loop, receive_loop], return_when=asyncio.FIRST_COMPLETED)
369-
done.pop().result() # need for raise exception - reason of stop task
369+
await stream_writer.close()
370+
done.pop().result()
370371
except issues.Error as err:
371372
err_info = check_retriable_error(err, retry_settings, attempt)
372373
if not err_info.is_retriable:
@@ -379,12 +380,12 @@ async def _connection_loop(self):
379380
self._stop(err)
380381
return
381382
finally:
383+
if stream_writer:
384+
await stream_writer.close()
382385
for task in tasks:
383386
task.cancel()
384387
if tasks:
385388
await asyncio.wait(tasks)
386-
if stream_writer:
387-
await stream_writer.close()
388389

389390
async def _encode_loop(self):
390391
try:

0 commit comments

Comments
 (0)