Skip to content

Commit 2f95c2b

Browse files
Detect use after free and report instead of VERIFY (#26434)
2 parents 87705c8 + 4f9e02d commit 2f95c2b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

ydb/core/kqp/compile_service/kqp_compile_actor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,8 @@ class TKqpCompileActor : public TActorBootstrapped<TKqpCompileActor> {
438438
void InternalError(const TString message) {
439439
ALOG_ERROR(NKikimrServices::KQP_COMPILE_ACTOR, "Internal error"
440440
<< ", self: " << SelfId()
441-
<< ", message: " << message);
442-
441+
<< ", message: " << message
442+
<< ", query text: " << QueryId.Text);
443443

444444
NYql::TIssue issue(NYql::TPosition(), "Internal error while compiling query.");
445445
issue.AddSubIssue(MakeIntrusive<TIssue>(NYql::TPosition(), message));

yql/essentials/core/yql_gc_transformer.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ class TGcNodeTransformer : public TSyncTransformerBase {
2929
const auto range = ctx.UniqueNodes.equal_range(hash);
3030
for (auto jt = range.first; range.second != jt;) {
3131
if (jt->second == dead) {
32+
YQL_ENSURE(jt->second->UseCount()==0);
33+
YQL_ENSURE(jt->second->Dead());
3234
jt = ctx.UniqueNodes.erase(jt);
3335
} else {
3436
++jt;

0 commit comments

Comments
 (0)