Skip to content

Commit 31e7859

Browse files
XJIE6ydbot
authored andcommitted
Incorrect memory usage fix (#25725)
1 parent 434e9c6 commit 31e7859

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

ydb/core/formats/arrow/program/abstract.h

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,14 @@ class TFetchingCalculationPolicy: public IMemoryCalculationPolicy {
4848
return EStage::Fetching;
4949
}
5050
virtual ui64 GetReserveMemorySize(
51-
const ui64 blobsSize, const ui64 rawSize, const std::optional<ui32> limit, const ui32 recordsCount) const override {
52-
if (limit) {
53-
return std::max<ui64>(blobsSize, rawSize * (1.0 * *limit) / recordsCount);
54-
} else {
55-
return std::max<ui64>(blobsSize, rawSize);
56-
}
51+
const ui64 blobsSize, const ui64 rawSize, const std::optional<ui32> /*limit*/, const ui32 /*recordsCount*/) const override {
52+
return std::max<ui64>(blobsSize, rawSize);
53+
// FIXME after futher memory usage investagiation
54+
// if (limit) {
55+
// return std::max<ui64>(blobsSize, rawSize * (1.0 * *limit) / recordsCount);
56+
// } else {
57+
// return std::max<ui64>(blobsSize, rawSize);
58+
// }
5759
}
5860
};
5961

0 commit comments

Comments
 (0)