Cleanup 6

Author: GrigoriyPA

ydb/library/yql/dq/runtime/dq_output_channel.cpp

@@ -108,8 +108,8 @@ class TDqOutputChannel : public IDqOutputChannel {
             if (Packer.PackedSizeEstimate()) {
                 TryPack(/* force */ true);
             }
-            for (auto&& data : BlockSplitter->SplitItem(values, width)) {
-                DoPushBlock(std::move(data));
+            for (const auto& data : BlockSplitter->SplitItem(values, width)) {
+                DoPushBlock(data);
             }
         } else {
             DoPush(values, width);
@@ -131,8 +131,8 @@ class TDqOutputChannel : public IDqOutputChannel {
         TryPack(/* force */ false);
     }
 
-    void DoPushBlock(std::vector<arrow::Datum>&& data) {
-        Packer.AddBlockItem(std::move(data));
+    void DoPushBlock(const std::vector<arrow::Datum>& data) {
+        Packer.AddBlockItem(data);
 
         PackerCurrentChunkCount++;
         TryPack(/* force */ false);

yql/essentials/minikql/computation/mkql_computation_node_pack.cpp

@@ -1207,11 +1207,11 @@ TValuePackerTransport<Fast>& TValuePackerTransport<Fast>::AddWideItemBlocks(cons
     for (size_t i = 0; i < width; ++i) {
         data.emplace_back(TArrowBlock::From(values[i]).GetDatum());
     }
-    return AddBlockItem(std::move(data));
+    return AddBlockItem(data);
 }
 
 template<bool Fast>
-TValuePackerTransport<Fast>& TValuePackerTransport<Fast>::AddBlockItem(std::vector<arrow::Datum>&& data) {
+TValuePackerTransport<Fast>& TValuePackerTransport<Fast>::AddBlockItem(const std::vector<arrow::Datum>& data) {
     const auto width = data.size();
     MKQL_ENSURE(width == BlockSerializers_.size(), "Invalid width");
     const ui64 len = data[BlockLenIndex_].scalar_as<arrow::UInt64Scalar>().value;

yql/essentials/minikql/computation/mkql_computation_node_pack.h

@@ -88,7 +88,7 @@ class TValuePackerTransport {
     // AddItem()/UnpackBatch() will perform incremental packing - type T is processed as list item type. Will produce List<T> layout
     TSelf& AddItem(const NUdf::TUnboxedValuePod& value);
     TSelf& AddWideItem(const NUdf::TUnboxedValuePod* values, ui32 count);
-    TSelf& AddBlockItem(std::vector<arrow::Datum>&& data);
+    TSelf& AddBlockItem(const std::vector<arrow::Datum>& data);
     size_t PackedSizeEstimate() const {
         return IsBlock_ ? BlockBuffer_.Size() : (Buffer_ ? (Buffer_->Size() + Buffer_->ReservedHeaderSize()) : 0);
     }