Skip to content

Commit 7666614

Browse files
committed
Fix new secrets tests (#25549)
1 parent ef90259 commit 7666614

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

ydb/core/kqp/federated_query/kqp_federated_query_actors.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@ void TDescribeSchemaSecretsService::Handle(TEvTxProxySchemeCache::TEvNavigateKey
121121
return;
122122
}
123123

124-
// TODO (yurikiselev): Assert that request->ResultSet.front().SecretInfo->Description.GetValue() is empty [issue:23462]
124+
const auto& secretDescription = request->ResultSet.front().SecretInfo->Description;
125+
Y_ENSURE(!secretDescription.HasValue(), "SchemeCache must never contain secret values");
125126

126127
const auto secretIt = SecretNameToValue.find(secretName);
127128
if (secretIt != SecretNameToValue.end()) { // some secret version is in cache
@@ -137,6 +138,7 @@ void TDescribeSchemaSecretsService::Handle(TEvTxProxySchemeCache::TEvNavigateKey
137138
TAutoPtr<TEvTxUserProxy::TEvNavigate> req(new TEvTxUserProxy::TEvNavigate());
138139
NKikimrSchemeOp::TDescribePath* record = req->Record.MutableDescribePath();
139140
record->SetPath(secretName);
141+
record->MutableOptions()->SetReturnSecretValue(true);
140142
// TODO(yurikiselev): Deal with UserToken [issue:25472]
141143
Send(MakeTxProxyID(), req.Release(), 0, ev->Cookie);
142144
}

0 commit comments

Comments
 (0)