Return smart pointer in MakeHarmonizer (#14749)

Author: kruall

ydb/library/actors/core/cpu_manager.cpp

@@ -86,7 +86,7 @@ namespace NActors {
         }
 
         ui64 ts = GetCycleCountFast();
-        Harmonizer.reset(MakeHarmonizer(ts));
+        Harmonizer = MakeHarmonizer(ts);
         Harmonizer->SetSharedPool(Shared.get());
 
         Executors.Reset(new TAutoPtr<IExecutorPool>[ExecutorPoolCount]);

ydb/library/actors/core/harmonizer/harmonizer.cpp

@@ -398,8 +398,8 @@ void THarmonizer::Enable(bool enable) {
     IsDisabled = enable;
 }
 
-IHarmonizer* MakeHarmonizer(ui64 ts) {
-    return new THarmonizer(ts);
+std::unique_ptr<IHarmonizer> MakeHarmonizer(ui64 ts) {
+    return std::make_unique<THarmonizer>(ts);
 }
 
 TPoolHarmonizerStats THarmonizer::GetPoolStats(i16 poolId) const {

ydb/library/actors/core/harmonizer/harmonizer.h

@@ -64,5 +64,5 @@ namespace NActors {
         virtual void SetSharedPool(ISharedPool* pool) = 0;
     };
 
-    IHarmonizer* MakeHarmonizer(ui64 ts);
+    std::unique_ptr<IHarmonizer> MakeHarmonizer(ui64 ts);
 }

ydb/library/actors/core/ut/actor_ut.cpp

@@ -494,9 +494,9 @@ Y_UNIT_TEST_SUITE(TestDecorator) {
         setup->Executors.Reset(new TAutoPtr<IExecutorPool>[setup->ExecutorsCount]);
 
         ui64 ts = GetCycleCountFast();
-        THolder<IHarmonizer> harmonizer(MakeHarmonizer(ts));
+        std::unique_ptr<IHarmonizer> harmonizer = MakeHarmonizer(ts);
         for (ui32 i = 0; i < setup->ExecutorsCount; ++i) {
-            setup->Executors[i] = new TBasicExecutorPool(i, 1, 10, "basic", harmonizer.Get());
+            setup->Executors[i] = new TBasicExecutorPool(i, 1, 10, "basic", harmonizer.get());
             harmonizer->AddPool(setup->Executors[i].Get());
         }
         setup->Scheduler = new TBasicSchedulerThread;
@@ -626,9 +626,9 @@ Y_UNIT_TEST_SUITE(TestAliases) {
         setup->Executors.Reset(new TAutoPtr<IExecutorPool>[setup->ExecutorsCount]);
 
         ui64 ts = GetCycleCountFast();
-        THolder<IHarmonizer> harmonizer(MakeHarmonizer(ts));
+        std::unique_ptr<IHarmonizer> harmonizer = MakeHarmonizer(ts);
         for (ui32 i = 0; i < setup->ExecutorsCount; ++i) {
-            setup->Executors[i] = new TBasicExecutorPool(i, 1, 10, "basic", harmonizer.Get());
+            setup->Executors[i] = new TBasicExecutorPool(i, 1, 10, "basic", harmonizer.get());
             harmonizer->AddPool(setup->Executors[i].Get());
         }
         setup->Scheduler = new TBasicSchedulerThread;

ydb/library/actors/testlib/test_runtime.cpp

@@ -1731,7 +1731,7 @@ namespace NActors {
 
         IHarmonizer* harmonizer = nullptr;
         if (node) {
-            node->Harmonizer.reset(MakeHarmonizer(GetCycleCountFast()));
+            node->Harmonizer = MakeHarmonizer(GetCycleCountFast());
             harmonizer = node->Harmonizer.get();
         }