25-3-1: Fix use-after-free (#25842)

CyberROFL · web-flow · commit 8355af09c140 · 2025-09-26T13:59:28.000+03:00
diff --git a/ydb/core/mind/hive/hive_events.h b/ydb/core/mind/hive/hive_events.h
@@ -89,9 +89,9 @@ struct TEvPrivate {
 
     struct TEvRestartComplete : TEventLocal<TEvRestartComplete, EvRestartComplete> {
         TFullTabletId TabletId;
-        TStringBuf Status;
+        TString Status;
 
-        TEvRestartComplete(TFullTabletId tabletId, TStringBuf status)
+        TEvRestartComplete(TFullTabletId tabletId, const TString& status)
             : TabletId(tabletId)
             , Status(status)
         {}
diff --git a/ydb/core/mind/hive/tablet_info.cpp b/ydb/core/mind/hive/tablet_info.cpp
@@ -545,7 +545,7 @@ bool TTabletInfo::RestartsOften() const {
     return Statistics.RestartTimestampSize() >= Hive.GetTabletRestartsMaxCount();
 }
 
-void TTabletInfo::NotifyOnRestart(TString status, TSideEffects& sideEffects) {
+void TTabletInfo::NotifyOnRestart(const TString& status, TSideEffects& sideEffects) {
     for (auto actorId : ActorsToNotifyOnRestart) {
         sideEffects.Send(actorId, new TEvPrivate::TEvRestartComplete(GetFullTabletId(), status));
     }
diff --git a/ydb/core/mind/hive/tablet_info.h b/ydb/core/mind/hive/tablet_info.h
@@ -310,7 +310,7 @@ struct TTabletInfo {
         return std::get<NMetrics::EResource::Counter>(GetResourceCurrentValues()) > 0;
     }
 
-    void NotifyOnRestart(TString status, TSideEffects& sideEffects);
+    void NotifyOnRestart(const TString& status, TSideEffects& sideEffects);
 };
 
 

Original file line number	Diff line number	Diff line change
`@@ -545,7 +545,7 @@ bool TTabletInfo::RestartsOften() const {`
`545`	`545`	`return Statistics.RestartTimestampSize() >= Hive.GetTabletRestartsMaxCount();`
`546`	`546`	`}`
`547`	`547`
`548`		`-void TTabletInfo::NotifyOnRestart(TString status, TSideEffects& sideEffects) {`
	`548`	`+void TTabletInfo::NotifyOnRestart(const TString& status, TSideEffects& sideEffects) {`
`549`	`549`	`for (auto actorId : ActorsToNotifyOnRestart) {`
`550`	`550`	`sideEffects.Send(actorId, new TEvPrivate::TEvRestartComplete(GetFullTabletId(), status));`
`551`	`551`	`}`
Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,7 @@ struct TTabletInfo {`
`310`	`310`	`return std::get<NMetrics::EResource::Counter>(GetResourceCurrentValues()) > 0;`
`311`	`311`	`}`
`312`	`312`
`313`		`- void NotifyOnRestart(TString status, TSideEffects& sideEffects);`
	`313`	`+ void NotifyOnRestart(const TString& status, TSideEffects& sideEffects);`
`314`	`314`	`};`
`315`	`315`
`316`	`316`