add validation for different precisions

Author: gridnevvvit

ydb/core/kqp/ut/query/kqp_query_ut.cpp

@@ -74,6 +74,58 @@ Y_UNIT_TEST_SUITE(KqpQuery) {
         UNIT_ASSERT_VALUES_EQUAL(counters.RecompileRequestGet()->Val(), 1);
     }
 
+    Y_UNIT_TEST_QUAD(DecimalOutOfPrecision, UseOltpSink, EnableParameterizedDecimal) {
+        TKikimrSettings serverSettings;
+        serverSettings.AppConfig.MutableTableServiceConfig()->SetEnableOltpSink(UseOltpSink);
+        serverSettings.FeatureFlags.SetEnableParameterizedDecimal(EnableParameterizedDecimal);
+        serverSettings.WithSampleTables = false;
+
+        TKikimrRunner kikimr(serverSettings);
+        auto client = kikimr.GetQueryClient();
+
+        {
+            auto ddlResult = client.ExecuteQuery(R"(
+                CREATE TABLE DecTest (
+                    Key Int32 NOT NULL,
+                    Value Decimal(22, 9) NOT NULL,
+                    PRIMARY KEY (Key)
+                );
+            )", NYdb::NQuery::TTxControl::NoTx()).ExtractValueSync();
+            UNIT_ASSERT_C(ddlResult.IsSuccess(), ddlResult.GetIssues().ToString());
+        }
+
+        // 10000000000000 in Decimal(35, 9), invalid for Decimal(22, 9)
+        Ydb::Value value;
+        value.set_low_128(1864712049423024128);
+        value.set_high_128(542);
+        auto invalidValue = TDecimalValue(value, NYdb::TDecimalType(22, 9));
+
+        {
+            auto params = TParamsBuilder()
+                .AddParam("$value").Decimal(invalidValue).Build()
+                .Build();
+
+            auto writeResult = client.ExecuteQuery(R"(
+                UPSERT INTO DecTest (Key, Value) VALUES
+                    (1, CAST(10 AS Decimal(22,9))),
+                    (2, $value),
+                    (3, $value - CAST(1 AS Decimal(22,9)));
+            )", NYdb::NQuery::TTxControl::BeginTx().CommitTx(), params).ExtractValueSync();
+
+            // TODO: Plan A, query should fail as provided value is invalid for given type.
+            UNIT_ASSERT_C(writeResult.IsSuccess(), writeResult.GetIssues().ToString());
+
+            // TODO: Plan B, value for key 2 should be inf, as provided value is out of range
+            // for given type.
+            auto session = kikimr.GetTableClient().CreateSession().GetValueSync().GetSession();
+            auto tableYson = ReadTableToYson(session, "/Root/DecTest");
+            CompareYson(R"([
+                [[1];["10"]];
+                [[2];["inf"]];
+                [[3];["inf"]]])", tableYson);
+        }
+    }
+
     Y_UNIT_TEST(QueryCache) {
         TKikimrRunner kikimr;
         auto db = kikimr.GetTableClient();

ydb/library/mkql_proto/mkql_proto.cpp

@@ -1628,7 +1628,22 @@ Y_FORCE_INLINE NUdf::TUnboxedValue KindDataImport(const TType* type, const Ydb::
             return MakeString(value.bytes_value());
         }
         case NUdf::TDataType<NUdf::TDecimal>::Id: {
-            return NUdf::TUnboxedValuePod(NYql::NDecimal::FromHalfs(value.low_128(), value.high_128()));
+            auto data = NYql::NDecimal::FromHalfs(value.low_128(), value.high_128());
+            auto dataType = static_cast<const TDataType*>(type);
+            auto schemeType = dataType->GetSchemeType();
+            if (schemeType != NYql::NProto::TypeIds::Decimal) {
+                throw yexception() << "Expected decimal type, but found " << schemeType;
+            }
+            auto decimalType = static_cast<const TDataDecimalType *>(dataType);
+            auto params = decimalType->GetParams();
+            ui8 precision = params.first;
+            Y_ENSURE(precision <= NYql::NDecimal::MaxPrecision, "Unsupported decimal precision: " << precision);
+            if (NYql::NDecimal::IsError(data)) {
+                throw yexception() << "Invalid Decimal value";
+            }
+            Y_ENSURE(NYql::NDecimal::IsNormal(precision, data),
+                "Invalid Decimal value out of the range for specified precision: " << precision);
+            return NUdf::TUnboxedValuePod(data);
         }
         default: {
             throw yexception() << "Unsupported data type: " << dataType->GetSchemeType();

yql/essentials/public/decimal/yql_decimal.cpp

@@ -8,6 +8,45 @@
 namespace NYql {
 namespace NDecimal {
 
+constexpr std::array<std::pair<TInt128, TInt128>, MaxPrecision + 1> DecimalBounds_ = {
+    NYql::NDecimal::GetBounds<0>(),
+    NYql::NDecimal::GetBounds<1>(),
+    NYql::NDecimal::GetBounds<2>(),
+    NYql::NDecimal::GetBounds<3>(),
+    NYql::NDecimal::GetBounds<4>(),
+    NYql::NDecimal::GetBounds<5>(),
+    NYql::NDecimal::GetBounds<6>(),
+    NYql::NDecimal::GetBounds<7>(),
+    NYql::NDecimal::GetBounds<8>(),
+    NYql::NDecimal::GetBounds<9>(),
+    NYql::NDecimal::GetBounds<10>(),
+    NYql::NDecimal::GetBounds<11>(),
+    NYql::NDecimal::GetBounds<12>(),
+    NYql::NDecimal::GetBounds<13>(),
+    NYql::NDecimal::GetBounds<14>(),
+    NYql::NDecimal::GetBounds<15>(),
+    NYql::NDecimal::GetBounds<16>(),
+    NYql::NDecimal::GetBounds<17>(),
+    NYql::NDecimal::GetBounds<18>(),
+    NYql::NDecimal::GetBounds<19>(),
+    NYql::NDecimal::GetBounds<20>(),
+    NYql::NDecimal::GetBounds<21>(),
+    NYql::NDecimal::GetBounds<22>(),
+    NYql::NDecimal::GetBounds<23>(),
+    NYql::NDecimal::GetBounds<24>(),
+    NYql::NDecimal::GetBounds<25>(),
+    NYql::NDecimal::GetBounds<26>(),
+    NYql::NDecimal::GetBounds<27>(),
+    NYql::NDecimal::GetBounds<28>(),
+    NYql::NDecimal::GetBounds<29>(),
+    NYql::NDecimal::GetBounds<30>(),
+    NYql::NDecimal::GetBounds<31>(),
+    NYql::NDecimal::GetBounds<32>(),
+    NYql::NDecimal::GetBounds<33>(),
+    NYql::NDecimal::GetBounds<34>(),
+    NYql::NDecimal::GetBounds<35>(),
+};
+
 static const TUint128 Ten(10U);
 
 TUint128 GetDivider(ui8 scale) {
@@ -459,5 +498,11 @@ TInt128 MulAndDivNormalDivider(TInt128 a, TInt128 b, TInt128 c) {
     return Normalize(Div<false>(WidenMul(a, b), TInt256(c)));
 }
 
+bool IsNormal(ui8 precision, TInt128 v) {
+    YQL_ENSURE(precision < DecimalBounds_.size(), "Unsupported decimal precision: %d", precision);
+    const auto& db = DecimalBounds_[precision];
+    return v > db.first && v < db.second;
+}
+
 }
 }

yql/essentials/public/decimal/yql_decimal.h

@@ -73,6 +73,8 @@ inline bool IsNormal(TInt128 v) {
     return v > b.first && v < b.second;
 }
 
+inline bool IsNormal(ui8 precision, TInt128 v);
+
 const char* ToString(TInt128 v, ui8 precision, ui8 scale = 0);
 TInt128 FromString(const TStringBuf& str, ui8 precision, ui8 scale = 0);