Skip to content

Conversation

neyrox
Copy link
Contributor

@neyrox neyrox commented Oct 8, 2025

Changelog entry

C++ unit test for

SELECT vn FROM table LIMIT 1;

on table with PK(id) and data column vn with COLUMN store

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Simple test for SyncPointLimitControl bag when data source comes without PK

Copy link

github-actions bot commented Oct 8, 2025

🟢 2025-10-08 11:38:34 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Oct 8, 2025

2025-10-08 11:39:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4bae53e has started.
2025-10-08 11:39:40 UTC Artifacts will be uploaded here
2025-10-08 11:42:20 UTC ya make is running...
🟢 2025-10-08 11:44:59 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 193 0 0 0 0

🟢 2025-10-08 11:45:02 UTC Build successful.

Copy link

github-actions bot commented Oct 8, 2025

2025-10-08 11:39:39 UTC Pre-commit check linux-x86_64-release-asan for 4bae53e has started.
2025-10-08 11:39:53 UTC Artifacts will be uploaded here
2025-10-08 11:42:23 UTC ya make is running...
🟡 2025-10-08 11:54:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 191 0 2 0 0

🟢 2025-10-08 11:54:56 UTC Build successful.

@neyrox neyrox marked this pull request as ready for review October 8, 2025 13:22
@neyrox neyrox requested a review from a team as a code owner October 8, 2025 13:22
@neyrox neyrox requested a review from dahbka-lis October 9, 2025 08:07
sts.SetColumnShardReaderClassName("SIMPLE");
sts.AppConfig.MutableTableServiceConfig()->SetAllowOlapDataQuery(true);
TKikimrRunner kikimr(sts);
auto db = kikimr.GetTableClient();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetTableClient() выполняет запросы через устаревший TableService. Сейчас наш единый сервис для DDL/DML/другие является QueryService, которым можно воспользоваться через GetQueryClient().

Примеры:


// Then
result.GetIssues().PrintTo(Cerr);
UNIT_ASSERT(result.IsSuccess());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_ASSERT_C(result.IsSuccess(), result.GetIssues().ToString());

INSERT INTO `/Root/KV` (id, vn) VALUES (1, 11);
)"), TTxControl::BeginTx().CommitTx()).ExtractValueSync();
result.GetIssues().PrintTo(Cerr);
UNIT_ASSERT(result.IsSuccess());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_ASSERT_C(result.IsSuccess(), result.GetIssues().ToString());

Copy link
Member

@dahbka-lis dahbka-lis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется, данные тесты должны лежать в этой папке:
https://github.com/ydb-platform/ydb/tree/main/ydb/core/kqp/ut/olap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants