add minShares to vault withdrawals

[lbertenasco]

it's not the best UX when you desire to withdraw 100 shares that it will only consume 50.
should add minShares as a parameter and revert if it cannot fill the withdraw

[pandadefi]

You end up spending a lot of gas and at the end it will revert, does that make sense?

[0xparashar]

Added changes here https://github.com/ankitiitb1069/yearn-vaults/tree/add-minshares-to-vault-withdrawal, can I raise a PR for this now?

[lbertenasco]

You end up spending a lot of gas and at the end it will revert, does that make sense?

yes, because metamask will tell you it's a reverted tx, and you won't end up sending that tx at all.

also @ankitiitb1069 please add tests and submit a PR and we'll gladly review it :)

[parseb]

@ankitiitb1069 did you submit a PR for this?

[pandadefi]

@parseb he didn't, do you want to take were he left and add tests?

[parseb]

@pandadefi on it, if PR not linked in 48h, assume the worst.

[parseb]

Spent hours trying to fix this.
Not the only one getting this error. (0 confirmations)
I'm also likely the worst person to try and solve it since I'm new to everything in this env.

[0xbok]

Hey @parseb, i'll try to give this a shot if you're okay?

[parseb]

Hey @parseb, i'll try to give this a shot if you're okay?

yes. please do.

[0xbok]

@pandadefi, sent this PR #517.

[pandadefi]

We are working on a new version of the vault that will not be based on this code. We aren't going to make a new release on top of that.

[0xbok]

got it, I'll close the PR.

[0xbok]

@pandadefi any help you need on the new version of vaults?

[pandadefi]

We are still in the planning phase