v4

yegor256 · yegor256 · commit 1b561b7e0eb1 · 2025-01-23T13:55:26.000+03:00
diff --git a/.gitattributes b/.gitattributes
@@ -1,7 +1,7 @@
 # Check out all text files in UNIX format.
 * text eol=lf
 
-# Explicitly declare text files we want to always be normalized and converted 
+# Explicitly declare text files we want to always be normalized and converted
 # to native line endings on checkout.
 *.txt text
 *.java text
diff --git a/.github/workflows/mvn.yml b/.github/workflows/mvn.yml
@@ -26,4 +26,4 @@ jobs:
           key: ${{ runner.os }}-jdk-${{ matrix.java }}-maven-${{ hashFiles('**/pom.xml') }}
           restore-keys: |
             ${{ runner.os }}-jdk-${{ matrix.java }}-maven-
-      - run: mvn -B install -Pqulice
+      - run: mvn -B install -Pqulice
diff --git a/.github/workflows/up.yml b/.github/workflows/up.yml
@@ -13,7 +13,7 @@ jobs:
   up:
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
+      - uses: actions/checkout@v4
       - run: |-
           git fetch --tags --force && \
           latest=$(git tag --sort=creatordate | tail -1) && \
@@ -25,4 +25,4 @@ jobs:
           delete-branch: true
           title: 'New version in README'
           assignees: yegor256
-          base: master
+          base: master
diff --git a/README.md b/README.md
@@ -58,7 +58,7 @@ Read this short summary of [typical mistakes](https://github.com/yegor256/qulice
 you may encounter in your project.
 
 In order to download schemas required for XML validation you might need proxy
-setup. Maven proxy is not supported, but standard 
+setup. Maven proxy is not supported, but standard
 [JVM proxy](https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html)
 works fine. To use it just add `-Dhttp.proxyHost=HOST -Dhttp.proxyPort=PORT`
 to your `MAVEN_OPTS` environment variable or to Maven command, e.g.
diff --git a/qulice-checkstyle/src/main/java/com/qulice/checkstyle/JavadocTagsCheck.java b/qulice-checkstyle/src/main/java/com/qulice/checkstyle/JavadocTagsCheck.java
@@ -228,4 +228,3 @@ private List<Integer> findTagLineNum(
         return found;
     }
 }
-
diff --git a/qulice-checkstyle/src/site/apt/index.apt.vm b/qulice-checkstyle/src/site/apt/index.apt.vm
@@ -44,4 +44,3 @@ Checkstyle Module
   {{{http://checkstyle.sourceforge.net/}Checkstyle}} static analysis tool
   and pre-configures it. Full configuration we're using is available in
   {{{http://trac.fazend.com/qulice/browser/qulice/tags/qulice-${project.version}/qulice/qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml}<<<checks.xml>>>}}.
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/AnnotationConstant.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/AnnotationConstant.java
@@ -80,4 +80,3 @@ public String other() {
         return String.valueOf(this.dat);
     }
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/CommentCheck/Invalid.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/CommentCheck/Invalid.java
@@ -19,4 +19,3 @@ public void main() {
      */
     private static String OTHER_TEXT = "some text";
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/CommentCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/CommentCheck/violations.txt
@@ -2,4 +2,4 @@
 9:The first sentence in a multiline comment should start with a capital letter, even if the comment begins with two asterisks.
 9:The first sentence in a single-line comment should start with a capital letter.
 15:The first sentence in a multiline comment should start with a capital letter.
-19:The first sentence in a multiline comment should start with a capital letter, even if the comment begins with two asterisks.
+19:The first sentence in a multiline comment should start with a capital letter, even if the comment begins with two asterisks.
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ConstantUsageCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ConstantUsageCheck/violations.txt
@@ -1,2 +1,2 @@
 6:Private constant "INSTANCE" is not used
-7:Private constant "OTHER_INSTANCE" is not used
+7:Private constant "OTHER_INSTANCE" is not used
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/CurlyBracketsStructureCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/CurlyBracketsStructureCheck/violations.txt
@@ -9,4 +9,4 @@
 37:Closing bracket should be on a new line
 40:Closing bracket should be on a new line
 41:Parameters should start on a new line
-45:Closing bracket should be on a new line
+45:Closing bracket should be on a new line
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/JavadocEmptyLineCheck/Valid.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/JavadocEmptyLineCheck/Valid.java
@@ -134,4 +134,4 @@ enum ValidEnum {
      * @return Return
      */
     int someValue();
-}
+}
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/JavadocParameterOrderCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/JavadocParameterOrderCheck/violations.txt
@@ -10,4 +10,4 @@
 70:Javadoc parameter order different than method signature
 71:Javadoc parameter order different than method signature
 72:Javadoc parameter order different than method signature
-82:Number of javadoc parameters different than method signature
+82:Number of javadoc parameters different than method signature
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/JavadocTagsCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/JavadocTagsCheck/violations.txt
@@ -1,3 +1,3 @@
 6:Missing '@since' tag in class/interface comment
 15:Tag text 'a1.0' does not match the pattern '^\d+(\.\d+){1,2}(\.[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?$'
-25:Missing '@since' tag in class/interface comment
+25:Missing '@since' tag in class/interface comment
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/MethodBodyCommentsCheck/Invalid.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/MethodBodyCommentsCheck/Invalid.java
@@ -39,4 +39,3 @@ public void run() {
         };
     }
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/MethodsOrderCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/MethodsOrderCheck/violations.txt
@@ -3,4 +3,3 @@
 25:Wrong method declaration order
 27:Wrong method declaration order
 42:Wrong method declaration order
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/NoJavadocForOverriddenMethodsCheck/Valid.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/NoJavadocForOverriddenMethodsCheck/Valid.java
@@ -24,13 +24,13 @@ public void inherit() {
      */
     public void doc() {
     }
-    
+
     //todo
     @Override
     public void good() {
     }
-    
-    /* 
+
+    /*
     comment
     */
     @Override
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProhibitUnusedPrivateConstructorCheck/Invalid.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProhibitUnusedPrivateConstructorCheck/Invalid.java
@@ -20,4 +20,4 @@ public static Invalid create() {
         return new Invalid("0");
     }
 
-}
+}
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProhibitUnusedPrivateConstructorCheck/Valid.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProhibitUnusedPrivateConstructorCheck/Valid.java
@@ -15,4 +15,4 @@ private Valid(int i) {
         this.i = i;
     }
 
-}
+}
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProhibitUnusedPrivateConstructorCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProhibitUnusedPrivateConstructorCheck/violations.txt
@@ -1 +1 @@
-15:Unused private constructor.
+15:Unused private constructor.
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProtectedMethodInFinalClassCheck/violations.txt b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/ProtectedMethodInFinalClassCheck/violations.txt
@@ -1,4 +1,4 @@
 9:Final class should not contain protected methods
 11:Final class should not contain protected methods
 14:Final class should not contain protected methods
-22:Protected method is overriding default scoped method
+22:Protected method is overriding default scoped method
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ConstructorParams.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ConstructorParams.java
@@ -30,4 +30,3 @@ public int addNumber(final int number) {
         return this.number + number;
     }
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/DefaultMethods.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/DefaultMethods.java
@@ -27,4 +27,3 @@ default void forEach(final Consumer<String> action) {
         }
     }
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/InstanceMethodRef.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/InstanceMethodRef.java
@@ -23,4 +23,3 @@ private static void doSomething(final String value) {
         System.out.println(value);
     }
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/LineWrapPackage.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/LineWrapPackage.java
@@ -16,4 +16,3 @@ public interface LineWrapPackage {
     Integer data();
 
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ParametrizedClass.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ParametrizedClass.java
@@ -17,4 +17,3 @@ public interface ParametrizedClass<T> {
     List<T> data();
 
 }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/WindowsEol.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/WindowsEol.java
@@ -9,4 +9,3 @@
  * @since 1.0
  */
 public class WindowsEol { }
-
diff --git a/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/WindowsEolLinux.java b/qulice-checkstyle/src/test/resources/com/qulice/checkstyle/WindowsEolLinux.java
@@ -9,4 +9,3 @@
  * @since 1.0
  */
 public class WindowsEolLinux { }
-
diff --git a/qulice-maven-plugin/src/it/checkstyle-newlines/invoker.properties b/qulice-maven-plugin/src/it/checkstyle-newlines/invoker.properties
@@ -1,3 +1,3 @@
 invoker.goals = clean verify
 invoker.buildResult = failure
-invoker.mavenOpts=-Dline.separator=\r\n
+invoker.mavenOpts=-Dline.separator=\r\n
diff --git a/qulice-maven-plugin/src/it/checkstyle-newlines/src/main/java/com/qulice/plugin/violations/Violations.java b/qulice-maven-plugin/src/it/checkstyle-newlines/src/main/java/com/qulice/plugin/violations/Violations.java
@@ -4,4 +4,3 @@ public void test() {
         System.setProperty("test", "test value");
     }
 }
-
diff --git a/qulice-maven-plugin/src/it/checkstyle-newlines/src/main/resources/tabs.txt b/qulice-maven-plugin/src/it/checkstyle-newlines/src/main/resources/tabs.txt
@@ -1 +1 @@
-This file contains	a tab.
+This file contains	a tab.
diff --git a/qulice-maven-plugin/src/it/checkstyle-violations/LICENSE.txt b/qulice-maven-plugin/src/it/checkstyle-violations/LICENSE.txt
@@ -26,4 +26,3 @@ HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
 STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 OF THE POSSIBILITY OF SUCH DAMAGE.
-
diff --git a/qulice-maven-plugin/src/it/checkstyle-violations/src/main/resources/tabs.txt b/qulice-maven-plugin/src/it/checkstyle-violations/src/main/resources/tabs.txt
@@ -1 +1 @@
-This file contains	a tab.
+This file contains	a tab.
diff --git a/qulice-maven-plugin/src/it/dependency-violations/verify.groovy b/qulice-maven-plugin/src/it/dependency-violations/verify.groovy
@@ -37,4 +37,4 @@ def log = new File(basedir, 'build.log')
 assert log.text.contains('Unused declared dependencies found')
 assert log.text.contains('1 dependency problem(s) found')
 assert log.text.contains('commons-lang:commons-lang:jar:2.5:compile')
-assert !log.text.contains('commons-io:commons-io:jar:2.0.1:compile')
+assert !log.text.contains('commons-io:commons-io:jar:2.0.1:compile')
diff --git a/qulice-maven-plugin/src/it/log-check/verify.groovy b/qulice-maven-plugin/src/it/log-check/verify.groovy
@@ -34,4 +34,3 @@
 def log = new File(basedir, 'build.log')
 assert log.text.contains('Checking compile classpath')
 assert log.text.contains('Qulice quality check completed')
-
diff --git a/qulice-maven-plugin/src/it/multi-module/src/.gitignore b/qulice-maven-plugin/src/it/multi-module/src/.gitignore
@@ -2,4 +2,4 @@
 # Without it Git don't see the folder
 *
 # Except this file
-!.gitignore
+!.gitignore
diff --git a/qulice-maven-plugin/src/it/pmd-violations/src/main/java/com/qulice/foo/Violations.java b/qulice-maven-plugin/src/it/pmd-violations/src/main/java/com/qulice/foo/Violations.java
@@ -113,4 +113,3 @@ public String something() {
         }
     }
 }
-
diff --git a/qulice-maven-plugin/src/it/pmd-violations/verify.groovy b/qulice-maven-plugin/src/it/pmd-violations/verify.groovy
@@ -37,5 +37,3 @@ assert !log.text.contains('java.lang.Error: Invalid escape character')
 // @see https://github.com/tpc2/qulice/issues/146
 //assert log.text.contains("Avoid creating unnecessary local variables like 'name'")
 //assert log.text.contains("Avoid creating unnecessary local variables like 'message'")
-
-
diff --git a/qulice-maven-plugin/src/site/apt/index.apt.vm b/qulice-maven-plugin/src/site/apt/index.apt.vm
@@ -63,4 +63,3 @@ Qulice Maven Plugin
 
   That's it. Your build will fail if you have quality problems. Read
   {{{../quality.html}this page}} about how you can fix them.
-
diff --git a/qulice-pmd/src/site/apt/index.apt.vm b/qulice-pmd/src/site/apt/index.apt.vm
@@ -43,4 +43,3 @@ PMD Module
   The module encapsulates {{{http://pmd.sourceforge.net/}PMD}} and
   pre-configures it with this
   {{{http://trac.fazend.com/qulice/browser/qulice/tags/qulice-${project.version}/qulice/qulice-pmd/src/main/resources/com/qulice/pmd/ruleset.xml}<<<ruleset.xml>>>}}.
-
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/CallSuperInConstructor.java b/qulice-pmd/src/test/resources/com/qulice/pmd/CallSuperInConstructor.java
@@ -17,4 +17,4 @@ public CallSuperInConstructor(final int parameter, final int other) {
     public int num() {
         return number + another;
     }
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/CallToConstructorInConstructor.java b/qulice-pmd/src/test/resources/com/qulice/pmd/CallToConstructorInConstructor.java
@@ -7,7 +7,7 @@ public final class CallToConstructorInConstructor extends Super {
     public CallToConstructorInConstructor() {
         this(2);
     }
-    
+
     public CallToConstructorInConstructor(final int a) {
         super(a);
         this.number = 2;
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/EmptyInitializer.java b/qulice-pmd/src/test/resources/com/qulice/pmd/EmptyInitializer.java
@@ -5,4 +5,3 @@ class EmptyInitializer {
 
    {} // Again, why ?
 }
-
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/EmptyStatementNotInLoop.java b/qulice-pmd/src/test/resources/com/qulice/pmd/EmptyStatementNotInLoop.java
@@ -7,4 +7,3 @@ public void bar() {
         // the extra semicolon here this is not necessary
     }
 }
-
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/FieldInitOneConstructor.java b/qulice-pmd/src/test/resources/com/qulice/pmd/FieldInitOneConstructor.java
@@ -24,4 +24,4 @@ public Engine getEngine() {
     public Steering getSteering() {
         return steering;
     }
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/FieldInitSeveralConstructors.java b/qulice-pmd/src/test/resources/com/qulice/pmd/FieldInitSeveralConstructors.java
@@ -25,4 +25,4 @@ public Engine getEngine() {
     public Steering getSteering() {
         return steering;
     }
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/JunitStaticPublicMethods.java b/qulice-pmd/src/test/resources/com/qulice/pmd/JunitStaticPublicMethods.java
@@ -29,4 +29,4 @@ public static Collection parameters() {
         return Collections.EMPTY_LIST;
     }
 
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/LambdaInConstructor.java b/qulice-pmd/src/test/resources/com/qulice/pmd/LambdaInConstructor.java
@@ -27,4 +27,4 @@ public LambdaInConstructor(final int parameter, final int other) {
     public int num() {
         return number + another;
     }
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/NullCollection.java b/qulice-pmd/src/test/resources/com/qulice/pmd/NullCollection.java
@@ -7,4 +7,4 @@ class NullCollection {
     public final List<Object> method() {
         return null;
     }
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/RecordParsed.java b/qulice-pmd/src/test/resources/com/qulice/pmd/RecordParsed.java
@@ -5,4 +5,4 @@ public record RecordParsed(
         int line,
         String msg
 ) {
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/StaticPublicVoidMainMethod.java b/qulice-pmd/src/test/resources/com/qulice/pmd/StaticPublicVoidMainMethod.java
@@ -23,4 +23,4 @@ public int calculate() {
             return number;
         }
     }
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/UnderstandsMethodReferences.java b/qulice-pmd/src/test/resources/com/qulice/pmd/UnderstandsMethodReferences.java
@@ -11,4 +11,4 @@ public void test() {
     private static void other() {
         // body
     }
-}
+}
diff --git a/qulice-pmd/src/test/resources/com/qulice/pmd/UnusedImports.java b/qulice-pmd/src/test/resources/com/qulice/pmd/UnusedImports.java
@@ -7,4 +7,4 @@ public final class UnusedImports {
     public int method() {
         return null;
     }
-}
+}
diff --git a/qulice-spi/src/site/apt/index.apt.vm b/qulice-spi/src/site/apt/index.apt.vm
@@ -45,4 +45,3 @@ Service Programming Interface (SPI)
   {{{../qulice-maven-plugin}qulice-maven-plugin}}.
   {{{./apidocs-${project.version}/index.html}JavaDoc}} gives more
   details about the SPI.
-
diff --git a/src/site/apt/quality.apt.vm b/src/site/apt/quality.apt.vm
@@ -101,4 +101,3 @@ public void func() {
   // ...
 }
 +--
-
diff --git a/src/site/resources/logo.svg b/src/site/resources/logo.svg
@@ -35,4 +35,4 @@
 	</g>
 	<path fill="#2276A5" d="M0,0v42.763h0.025c0.544,19.926,35.013,38.943,35.013,38.943s34.399-18.922,35.01-38.943h0.027V0H0z"/>
 </g>
-</svg>
+</svg>

Original file line number	Diff line number	Diff line change
`@@ -228,4 +228,3 @@ private List<Integer> findTagLineNum(`
`228`	`228`	`return found;`
`229`	`229`	`}`
`230`	`230`	`}`
`231`		`-`
Original file line number	Diff line number	Diff line change
`@@ -80,4 +80,3 @@ public String other() {`
`80`	`80`	`return String.valueOf(this.dat);`
`81`	`81`	`}`
`82`	`82`	`}`
`83`		`-`
Original file line number	Diff line number	Diff line change
`@@ -19,4 +19,3 @@ public void main() {`
`19`	`19`	`*/`
`20`	`20`	`private static String OTHER_TEXT = "some text";`
`21`	`21`	`}`
`22`		`-`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`6:Private constant "INSTANCE" is not used`
`2`		`-7:Private constant "OTHER_INSTANCE" is not used`
	`2`	`+7:Private constant "OTHER_INSTANCE" is not used`