UnnecessaryLocalRule throws false-positive complaints #1509
Description
I'm getting these messages from qulice:
[INFO] PMD: eo-parser/src/test/java/org/eolang/parser/OnDetailedTest.java[31-31]: Avoid creating unnecessary local variables like 'xmir' (UnnecessaryLocalRule)
[INFO] PMD: eo-parser/src/test/java/org/eolang/parser/OnDetailedTest.java[33-33]: Avoid creating unnecessary local variables like 'source' (UnnecessaryLocalRule)For this code:
/*
* SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
* SPDX-License-Identifier: MIT
*/
package org.eolang.parser;
import com.jcabi.xml.XML;
import com.jcabi.xml.XMLDocument;
import com.yegor256.Mktmp;
import com.yegor256.MktmpResolver;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import org.hamcrest.MatcherAssert;
import org.hamcrest.Matchers;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
/**
* Tests for {@link OnDetailed}.
*
* @since 0.56.5
*/
@ExtendWith(MktmpResolver.class)
final class OnDetailedTest {
@Test
void reportsMoreClearly(@Mktmp final Path temp) throws IOException {
final XML xmir = new XMLDocument("<nothing/>");
final String expected = "f.xmir";
final Path source = temp.resolve(expected);
Files.write(source, xmir.toString().getBytes(StandardCharsets.UTF_8));
MatcherAssert.assertThat(
"Exception message is not detailed, as it should be",
Assertions.assertThrows(
Exception.class,
() -> new OnDetailed(new OnDefault(xmir), source).get(),
"Exception was not thrown, but it should, since object name is not here"
).getLocalizedMessage(),
Matchers.containsString(expected)
);
}
}As you can see, the both variables are used several times. Thus, we can't call them unnecessary.