Skip to content

Commit 587c922

Browse files
authored
chore: bump @yeoman/eslint (#283)
1 parent cff796d commit 587c922

File tree

9 files changed

+1156
-861
lines changed

9 files changed

+1156
-861
lines changed

package-lock.json

Lines changed: 1109 additions & 814 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"@types/node": ">=18.19.130",
5555
"@vitest/coverage-v8": "^4.0.18",
5656
"@yeoman/adapter": "^4.0.2",
57-
"@yeoman/eslint": "0.2.0",
57+
"@yeoman/eslint": "^1.0.0",
5858
"coveralls": "^3.1.1",
5959
"husky": "^9.1.7",
6060
"jsdoc": "^4.0.5",

src/run-context.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ export class RunContextBase<GeneratorType extends BaseGenerator = DefaultGenerat
336336
*/
337337
withArguments(arguments_: string | string[]): this {
338338
const argumentsArray = typeof arguments_ === 'string' ? arguments_.split(' ') : arguments_;
339-
assert(Array.isArray(argumentsArray), 'args should be either a string separated by spaces or an array');
339+
assert.ok(Array.isArray(argumentsArray), 'args should be either a string separated by spaces or an array');
340340
this.args = [...this.args, ...argumentsArray];
341341
return this;
342342
}
@@ -407,7 +407,7 @@ export class RunContextBase<GeneratorType extends BaseGenerator = DefaultGenerat
407407
*/
408408

409409
withGenerators(dependencies: Dependency[]): this {
410-
assert(Array.isArray(dependencies), 'dependencies should be an array');
410+
assert.ok(Array.isArray(dependencies), 'dependencies should be an array');
411411
return this.onEnvironment(async environment => {
412412
for (const dependency of dependencies) {
413413
if (typeof dependency === 'string') {
@@ -497,7 +497,7 @@ export class RunContextBase<GeneratorType extends BaseGenerator = DefaultGenerat
497497
*/
498498

499499
withMockedGenerators(namespaces: string[]): this {
500-
assert(Array.isArray(namespaces), 'namespaces should be an array');
500+
assert.ok(Array.isArray(namespaces), 'namespaces should be an array');
501501
const mockedGenerators = Object.fromEntries(namespaces.map(namespace => [namespace, this.mockedGeneratorFactory()]));
502502
const dependencies: Dependency[] = Object.entries(mockedGenerators).map(([namespace, mock]) => [mock, { namespace }]);
503503
Object.assign(this.mockedGenerators, mockedGenerators);
@@ -509,7 +509,7 @@ export class RunContextBase<GeneratorType extends BaseGenerator = DefaultGenerat
509509
* @param localConfig - should look just like if called config.getAll()
510510
*/
511511
withLocalConfig(localConfig: any): this {
512-
assert(typeof localConfig === 'object', 'config should be an object');
512+
assert.ok(typeof localConfig === 'object', 'config should be an object');
513513
return this.onGenerator(generator => (generator as any).config.defaults(localConfig));
514514
}
515515

src/run-result.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ export default class RunResult<GeneratorType extends BaseGenerator = BaseGenerat
299299
let match = false;
300300
match = typeof regex === 'string' ? body.includes(regex) : regex.test(body);
301301

302-
assert(match, `${file} did not match '${regex}'. Contained:\n\n${body}`);
302+
assert.ok(match, `${file} did not match '${regex}'. Contained:\n\n${body}`);
303303
}
304304
}
305305

test/helpers.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ describe('yeoman-test', () => {
176176
'return a RunContext object',
177177
promisify(done => {
178178
const context = helpers.run(helpers.createDummyGenerator());
179-
assert(context instanceof RunContext);
179+
assert.ok(context instanceof RunContext);
180180
context.on('end', done);
181181
}),
182182
);
@@ -189,7 +189,7 @@ describe('yeoman-test', () => {
189189
const context = helpers.run('simple:app').withEnvironment(environment => {
190190
environment.register(require.resolve('./fixtures/generator-simple/app'));
191191
});
192-
assert(context instanceof RunContext);
192+
assert.ok(context instanceof RunContext);
193193
context.on('end', done);
194194
}),
195195
);
@@ -382,8 +382,8 @@ describe('yeoman-test', () => {
382382
.run(helpers.createDummyGenerator())
383383
.withFiles({ 'foo.txt': 'foo', 'foo.json': { foo: 'bar' } })
384384
.commitFiles();
385-
assert(existsSync(resolve(runResult.cwd, 'foo.txt')));
386-
assert(existsSync(resolve(runResult.cwd, 'foo.json')));
385+
assert.ok(existsSync(resolve(runResult.cwd, 'foo.txt')));
386+
assert.ok(existsSync(resolve(runResult.cwd, 'foo.json')));
387387
});
388388
});
389389

test/run-context-environment.spec.ts

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,12 @@ describe('RunContext running environment', () => {
5454
});
5555

5656
it('returns instanceof RunContext', () => {
57-
assert(context instanceof RunContext);
57+
assert.ok(context instanceof RunContext);
5858
});
5959

6060
it('promises a RunResult', () => {
6161
return context.run().then(runResult => {
62-
assert(runResult instanceof RunResult);
62+
assert.ok(runResult instanceof RunResult);
6363
});
6464
});
6565

@@ -77,7 +77,7 @@ describe('RunContext running environment', () => {
7777

7878
it('passes newErrorHandler to the environment', () => {
7979
return context.run().then(() => {
80-
assert(context.env.options.newErrorHandler);
80+
assert.ok(context.env.options.newErrorHandler);
8181
});
8282
});
8383
});
@@ -92,7 +92,7 @@ describe('RunContext running environment', () => {
9292

9393
it('runs the generator', () => {
9494
return context.run().then(() => {
95-
assert(context.env.generatorTestExecuted);
95+
assert.ok(context.env.generatorTestExecuted);
9696
});
9797
});
9898
});
@@ -115,7 +115,7 @@ describe('RunContext running environment', () => {
115115

116116
it('runs the generator', () => {
117117
return context.run().then(() => {
118-
assert(context.generator.shouldRun);
118+
assert.ok(context.generator.shouldRun);
119119
});
120120
});
121121
});
@@ -136,7 +136,7 @@ describe('RunContext running environment', () => {
136136

137137
it('runs the generator', () => {
138138
return context.run().then(() => {
139-
assert(context.env.generatorTestExecuted);
139+
assert.ok(context.env.generatorTestExecuted);
140140
});
141141
});
142142
});
@@ -152,14 +152,14 @@ describe('RunContext running environment', () => {
152152
});
153153

154154
it('registers every generator', () => {
155-
assert(context.env.get('simple:app'));
156-
assert(context.env.get('simple:composing'));
157-
assert(context.env.get('simple:throwing'));
155+
assert.ok(context.env.get('simple:app'));
156+
assert.ok(context.env.get('simple:composing'));
157+
assert.ok(context.env.get('simple:throwing'));
158158
});
159159

160160
it('runs the generator', () => {
161161
return context.run().then(() => {
162-
assert(context.env.generatorTestExecuted);
162+
assert.ok(context.env.generatorTestExecuted);
163163
});
164164
});
165165
});
@@ -181,14 +181,14 @@ describe('RunContext running environment', () => {
181181
});
182182

183183
it('registers every generator', () => {
184-
assert(context.env.get('simple:app'));
185-
assert(context.env.get('simple:composing'));
186-
assert(context.env.get('simple:throwing'));
184+
assert.ok(context.env.get('simple:app'));
185+
assert.ok(context.env.get('simple:composing'));
186+
assert.ok(context.env.get('simple:throwing'));
187187
});
188188

189189
it('runs the generator', () => {
190190
return context.run().then(() => {
191-
assert(context.env.generatorTestExecuted);
191+
assert.ok(context.env.generatorTestExecuted);
192192
});
193193
});
194194
});
@@ -205,7 +205,7 @@ describe('RunContext running environment', () => {
205205
return context.run().then(
206206
() => assert.fail(),
207207
error => {
208-
assert(/throwing error/.test(error.message));
208+
assert.ok(/throwing error/.test(error.message));
209209
},
210210
);
211211
});
@@ -228,7 +228,7 @@ describe('RunContext running environment', () => {
228228
.withArguments('simple:app')
229229
.run()
230230
.then(() => {
231-
assert(context.env.generatorTestExecuted);
231+
assert.ok(context.env.generatorTestExecuted);
232232
});
233233
});
234234

@@ -239,7 +239,7 @@ describe('RunContext running environment', () => {
239239
.then(
240240
() => assert.fail(),
241241
error => {
242-
assert(/throwing error/.test(error.message));
242+
assert.ok(/throwing error/.test(error.message));
243243
},
244244
);
245245
});

test/run-context.spec.ts

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe('RunContext', () => {
8383

8484
context
8585
.on('ready', async () => {
86-
assert(await context.env.get('simple:app'));
86+
assert.ok(await context.env.get('simple:app'));
8787
})
8888
.on('end', done);
8989
}),
@@ -118,7 +118,7 @@ describe('RunContext', () => {
118118
'accept generator constructor parameter (and assign gen:test as namespace)',
119119
promisify(done => {
120120
context.on('ready', async () => {
121-
assert(await context.env.get('gen:test'));
121+
assert.ok(await context.env.get('gen:test'));
122122
done();
123123
});
124124
}),
@@ -176,7 +176,7 @@ describe('RunContext', () => {
176176
context.cleanTestDirectory();
177177
assert.fail();
178178
} catch (error) {
179-
assert(error.message.includes('Cleanup test dir called with false tmpdir option.'));
179+
assert.ok(error.message.includes('Cleanup test dir called with false tmpdir option.'));
180180
}
181181
});
182182

@@ -374,12 +374,12 @@ describe('RunContext', () => {
374374
);
375375

376376
it('throws error at additional calls with dirPath', () => {
377-
assert(context.inDir(temporaryDirectory));
377+
assert.ok(context.inDir(temporaryDirectory));
378378
try {
379379
context.inDir(temporaryDirectory);
380380
assert.fail();
381381
} catch (error) {
382-
assert(error.message.includes('Test directory has already been set.'));
382+
assert.ok(error.message.includes('Test directory has already been set.'));
383383
}
384384
});
385385
});
@@ -455,7 +455,7 @@ describe('RunContext', () => {
455455
});
456456

457457
it('should set inDirSet & targetDirectory', () => {
458-
assert(!context.targetDirectory);
458+
assert.ok(!context.targetDirectory);
459459
context.cd(temporaryDirectory);
460460
assert.equal(context.targetDirectory, temporaryDirectory);
461461
});
@@ -472,7 +472,7 @@ describe('RunContext', () => {
472472
context.cd(path.join(temporaryDirectory, 'NOT_EXIST'));
473473
assert.fail();
474474
} catch (error) {
475-
assert(error.message.includes(temporaryDirectory));
475+
assert.ok(error.message.includes(temporaryDirectory));
476476
}
477477
});
478478
});
@@ -494,7 +494,7 @@ describe('RunContext', () => {
494494
promisify(done => {
495495
const callback = mock.fn(function (dir) {
496496
assert.equal(this, context);
497-
assert(dir.includes(tempDirectory));
497+
assert.ok(dir.includes(tempDirectory));
498498
});
499499

500500
context.inTmpDir(callback).on('end', done);
@@ -735,8 +735,8 @@ describe('RunContext', () => {
735735
describe('#withMockedGenerators()', () => {
736736
it('creates mocked generator', async () => {
737737
await context.withMockedGenerators(['foo:bar']).build();
738-
assert(await context.env.get('foo:bar'));
739-
assert(context.mockedGenerators['foo:bar']);
738+
assert.ok(await context.env.get('foo:bar'));
739+
assert.ok(context.mockedGenerators['foo:bar']);
740740
});
741741
});
742742

@@ -745,22 +745,22 @@ describe('RunContext', () => {
745745
'register paths',
746746
promisify(done => {
747747
context.withGenerators([require.resolve('./fixtures/generator-simple/app')]).on('ready', async () => {
748-
assert(await context.env.get('simple:app'));
748+
assert.ok(await context.env.get('simple:app'));
749749
done();
750750
});
751751
}),
752752
);
753753

754754
it('register paths with namespaces', async () => {
755755
await context.withGenerators([[require.resolve('./fixtures/generator-simple/app'), { namespace: 'foo:bar' }]]).build();
756-
assert(await context.env.get('foo:bar'));
756+
assert.ok(await context.env.get('foo:bar'));
757757
});
758758

759759
it(
760760
'register mocked generator',
761761
promisify(done => {
762762
context.withGenerators([[helpers.createDummyGenerator(), { namespace: 'dummy:gen' }]]).on('ready', async () => {
763-
assert(await context.env.get('dummy:gen'));
763+
assert.ok(await context.env.get('dummy:gen'));
764764
done();
765765
});
766766
}),
@@ -773,8 +773,8 @@ describe('RunContext', () => {
773773
.withGenerators([require.resolve('./fixtures/generator-simple/app')])
774774
.withGenerators([[helpers.createDummyGenerator(), { namespace: 'dummy:gen' }]])
775775
.on('ready', async () => {
776-
assert(await context.env.get('dummy:gen'));
777-
assert(await context.env.get('simple:app'));
776+
assert.ok(await context.env.get('dummy:gen'));
777+
assert.ok(await context.env.get('simple:app'));
778778
done();
779779
});
780780
}),
@@ -853,7 +853,7 @@ describe('RunContext', () => {
853853
return environment;
854854
})
855855
.on('ready', async () => {
856-
assert(await context.env.get('simple:app'));
856+
assert.ok(await context.env.get('simple:app'));
857857
done();
858858
});
859859
}),

test/run-result-assertions.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ describe('run-result-assertions', () => {
1515
description: 'using memory fs',
1616
options: { memFs },
1717
verify(runResult) {
18-
assert(runResult.fs);
18+
assert.ok(runResult.fs);
1919
},
2020
},
2121
{
2222
description: 'using node fs',
2323
verify(runResult) {
24-
assert(!runResult.fs);
24+
assert.ok(!runResult.fs);
2525
},
2626
},
2727
]) {

test/run-result.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,9 +281,9 @@ describe('run-result', () => {
281281

282282
result.assertGeneratorComposedOnce(mockedNamespace);
283283
result.assertGeneratorComposed(mockedNamespace);
284-
assert(result.getGeneratorComposeCount(mockedNamespace) === 1);
284+
assert.ok(result.getGeneratorComposeCount(mockedNamespace) === 1);
285285
assert.equal(result.getComposedGenerators().length, 1);
286-
assert(result.getComposedGenerators()[0] === mockedNamespace);
286+
assert.ok(result.getComposedGenerators()[0] === mockedNamespace);
287287

288288
result.assertGeneratorNotComposed('another:gen');
289289
});

0 commit comments

Comments
 (0)