fix: handle CRLF in element-newline (#272)

yeonjuan · web-flow · commit 23ad63e09b90 · 2025-01-24T23:00:05.000+09:00
diff --git a/packages/eslint-plugin/lib/rules/element-newline.js b/packages/eslint-plugin/lib/rules/element-newline.js
@@ -246,14 +246,14 @@ module.exports = {
      * @param {NewlineNode} node
      */
     function isNotNewlineEnd(node) {
-      return node.type !== `Text` || /\n\s*$/.test(node.value) === false;
+      return node.type !== `Text` || /(\n|\r\n)\s*$/.test(node.value) === false;
     }
 
     /**
      * @param {NewlineNode} node
      */
     function isNotNewlineStart(node) {
-      return node.type !== `Text` || /^\n/.test(node.value) === false;
+      return node.type !== `Text` || /^(\n|\r\n)/.test(node.value) === false;
     }
 
     /**
diff --git a/packages/eslint-plugin/tests/rules/element-newline.test.js b/packages/eslint-plugin/tests/rules/element-newline.test.js
@@ -14,6 +14,9 @@ ruleTester.run("element-newline", rule, {
 </html>
 `,
     },
+    {
+      code: "<body>\r\n<div></div>\r\n test\r\n</body>",
+    },
     {
       code: "<html>\r\n<body>\r\n</body>\r\n</html>",
     },
@@ -57,6 +60,14 @@ ruleTester.run("element-newline", rule, {
         },
       ],
     },
+    {
+      code: "<div>\r\n<span><a></a></span>\r\n</div>",
+      options: [
+        {
+          skip: ["div"],
+        },
+      ],
+    },
     {
       code: `
 <div>
