feat: add path operators for Uri<String> #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodetalkers
force-pushed
the
add_path_methods
branch
2 times, most recently
from
427cdf3 to
e50b873
Compare
Author
|
@yescallop will this be ok? After reading the rfc and reading the code, I found this crate is more standing than that of mozilla, so I want to help finish this project. This is my first pr for this crate |
Decodetalkers
force-pushed
the
add_path_methods
branch
5 times, most recently
from
dca8039 to
811d52e
Compare
Owner
|
I appreciate your effort to contribute, but I haven't been able to work on the project and likely won't be able to for a while. It is still maintained though. I'll take a look when I get a chance. |
Decodetalkers
force-pushed
the
add_path_methods
branch
from
811d52e to
ebb3b65
Compare
Contributor
|
LGTM FYI: File paths on Windows with |
eirnym
approved these changes
Apr 27, 2025
Decodetalkers
force-pushed
the
add_path_methods
branch
2 times, most recently
from
b159a34 to
e4f455b
Compare
some part copy from url lib
Decodetalkers
force-pushed
the
add_path_methods
branch
from
e4f455b to
0e4300e
Compare
Author
|
@yescallop Can you take a review? thanks |
Owner
|
I have not been able to gather my mind to consider this. Every time I think about it thoroughly it gives me a headache, to be honest. I will come back to this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some part copy from url lib
solve: #32