Merge branch 'release/2.8.2'

Author: Matthieu Honel

README.md

@@ -54,6 +54,7 @@ Since data is pulled from YWH platform to your server, only regular outbound web
     - removed the GUI from the default installation (use `pip install 'ywh2bt[gui]'` to include the GUI)
     - fixed an issue with github when the title of an issue is longer than 255 characters
     - fixed an issue with jira image previews when multiple attached images have the same name
+    - fixed an issue when a report/comment has no attachments and the description contains an invalid URL
 - v2.7:
     - added synchronization of "fix verification" logs when "Upload status updates" is checked
     - fixed an issue with jira when scope contains special markdown characters

docs/User-Guide.md

@@ -420,6 +420,7 @@ the content is put into a Markdown file which is attached to the issue or commen
 - References to a same uploaded attachment in different comments is not supported yet,
   i.e., if an attachment is referenced (either displayed inline or as a link) in several comments,
   only first one will be correctly handled.
+- The GUI is not compatible with python 3.8.0 on Windows 10 (for some reason)
 
 # Resources
 

docs/user-guide/User-Guide.html

@@ -4,7 +4,7 @@
   <meta charset="utf-8" />
   <meta name="generator" content="pandoc" />
   <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes" />
-  <meta name="keywords" content="md5sum=8139b00148bbe3104fb70ae5f6ef5726" />
+  <meta name="keywords" content="md5sum=59557af67638b92952595760ad5e564c" />
   <title>YWH2BT User Guide</title>
   <style>
     html {
@@ -842,6 +842,7 @@ <h2 data-number="5.6"><span class="header-section-number">5.6</span> Miscellaneo
 <li>Since v2.5.0, the <a href="https://www.yeswehack.com">Yes We Hack platform</a> API URL has been changed to <code>https://api.yeswehack.com</code>.</li>
 <li>Since v2.0.0, unlike in previous versions, setting a tracked report back to &quot;Ask for integration&quot; won&#39;t create a new issue in the tracker but update the existing one.</li>
 <li>References to a same uploaded attachment in different comments is not supported yet, i.e., if an attachment is referenced (either displayed inline or as a link) in several comments, only first one will be correctly handled.</li>
+<li>The GUI is not compatible with python 3.8.0 on Windows 10 (for some reason)</li>
 </ul>
 </section>
 </section>

docs/user-guide/User-Guide.pdf

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "ywh2bt"
-version = "2.8.1"
+version = "2.8.2"
 description = "ywh2bt - YesWeHack to Bug Tracker"
 readme = "README.md"
 authors = ["m.honel <m.honel@yeswehack.com>"]

pyproject.toml

@@ -159,6 +159,8 @@ def cleanup_attachments_and_urls_from_html(
     Returns:
         the cleaned html
     """
+    if not attachments:
+        return html, attachments
     clean_attachments = []
     clean_attachments_urls = []
     attachments_domains: Set[str] = set()

ywh2bt/core/html.py

@@ -1,4 +1,5 @@
 import unittest
+from typing import List
 
 from ywh2bt.core.api.models.report import Attachment
 from ywh2bt.core.html import (
@@ -115,6 +116,25 @@ def test_cleanup_attachments_and_urls_from_html(self) -> None:
 </a>""",
         )
 
+    def test_cleanup_attachments_and_urls_from_html_evil_domain(self) -> None:
+        attachments: List[Attachment] = []
+        html = """
+<a href="https://[EVIL_DOMAIN]/1234?ijkl">
+    https://ywh.domain/1234
+</a>"""
+        cleaned_html, cleaned_attachments = cleanup_attachments_and_urls_from_html(
+            html=html,
+            attachments=attachments,
+        )
+        self.assertEqual(0, len(cleaned_attachments))
+        self.assertEqual(
+            cleaned_html,
+            """
+<a href="https://[EVIL_DOMAIN]/1234?ijkl">
+    https://ywh.domain/1234
+</a>""",
+        )
+
     def _build_attachment(
         self,
         url: str,